Bug 115919

Summary: [css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, syoichi, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256, 116059    
Attachments:
Description Flags
Initial Patch none

Bear Travis
Reported 2013-05-10 10:57:27 PDT
To enable user testing, CSS Exclusions should be turned on in the WebKit nightlies. For this particular feature, which has a runtime and compile-time flag, this can be accomplished by setting the default value of the runtime flag to true.
Attachments
Initial Patch (5.91 KB, patch)
2013-05-10 11:42 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-05-10 11:42:30 PDT
Created attachment 201369 [details] Initial Patch
Dean Jackson
Comment 2 2013-05-13 11:07:52 PDT
Comment on attachment 201369 [details] Initial Patch Simon commented that it really should be areCSSExclusionsEnabled, but this is only the variable name so I don't think it matters.
WebKit Commit Bot
Comment 3 2013-05-13 11:36:35 PDT
Comment on attachment 201369 [details] Initial Patch Clearing flags on attachment: 201369 Committed r150025: <http://trac.webkit.org/changeset/150025>
WebKit Commit Bot
Comment 4 2013-05-13 11:36:37 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2013-05-13 13:34:31 PDT
This change has caused the following test to fail on EFL WK2: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r150025%20(8365)/fast/css/variables/var-inside-shape-diffs.html
Bear Travis
Comment 6 2013-05-13 13:39:57 PDT
Investigating test failure. If nothing else, Exclusions can be explicitly turned off for that test case.
Zoltan Arvai
Comment 9 2013-05-14 01:50:23 PDT
(In reply to comment #8) > Here is the right link, sorry for the noise: > > http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r150056%20%2835480%29/fast/css/variables/var-inside-shape-diffs.html CSS Variable is disabled on Qt. Next time I do more investigation before commenting, I swear :)
Bear Travis
Comment 10 2013-05-14 10:39:21 PDT
I have filed bug 116059 to track the css variable test regressions this patch has caused. fast/css/variables/var-inside-shape in particular is buggy.
Note You need to log in before you can comment on or make changes to this bug.