Bug 115610

Summary:

Add Support for mspace element

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cfleizach, commit-queue, dbarton, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, gyuyoung.kim, kling, macpherson, menard, mrobinson, rakuco, rego+ews, rniwa, xan.lopez

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.w3.org/TR/MathML/chapter3.html#presm.mspace

Bug Depends on:

118053

Bug Blocks:

115583, 84019, 99623

Attachments:

Description	Flags
WIP Patch	none
Patch V2	none
Patch V3	eflews.bot: commit-queue-
Patch V4	buildbot: commit-queue-
Patch V5	eflews.bot: commit-queue-
Patch V5 - bis	eflews.bot: commit-queue-
Patch V5 - try to build again	buildbot: commit-queue-
Patch V5 - ter	buildbot: commit-queue-
Patch V5 - quater	cfleizach: review-
Patch V6	eflews.bot: commit-queue-
Patch V7	none
Patch V8	cfleizach: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch V9	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch V10	cfleizach: review+, commit-queue: commit-queue-
Patch Final Version	none

Frédéric Wang (:fredw)

Reported 2013-05-05 01:23:54 PDT

I thought this was already supported and didn't report it before, but according to https://trac.webkit.org/wiki/MathML%20Status that's not the case. Supporting at least width/height/depth would be useful to help MathML generators to tweak the spacing of formulas. MathJax also uses negative spacing (negative width). Here is a convenient dynamic test: https://www.mozilla.org/projects/mathml/demo/mspace.html

Attachments
WIP Patch (9.00 KB, patch) 2013-05-16 15:02 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V2 (16.82 KB, patch) 2013-05-17 10:45 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V3 (26.38 KB, patch) 2013-05-18 07:31 PDT, Frédéric Wang (:fredw)	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch V4 (31.24 KB, patch) 2013-05-18 08:17 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Patch V5 (34.90 KB, patch) 2013-05-18 12:25 PDT, Frédéric Wang (:fredw)	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch V5 - bis (34.90 KB, patch) 2013-05-21 00:36 PDT, Frédéric Wang (:fredw)	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch V5 - try to build again (37.69 KB, patch) 2013-05-22 12:34 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Patch V5 - ter (37.90 KB, patch) 2013-06-04 15:08 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Patch V5 - quater (39.93 KB, patch) 2013-06-05 00:17 PDT, Frédéric Wang (:fredw)	cfleizach: review-	Details Formatted Diff Diff
Patch V6 (30.06 KB, patch) 2013-06-26 09:56 PDT, Frédéric Wang (:fredw)	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch V7 (30.74 KB, patch) 2013-06-28 10:13 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V8 (30.75 KB, patch) 2013-06-28 12:33 PDT, Frédéric Wang (:fredw)	cfleizach: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (666.58 KB, application/zip) 2013-06-28 13:43 PDT, Build Bot	no flags	Details
Patch V9 (31.18 KB, patch) 2013-06-28 13:59 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (480.37 KB, application/zip) 2013-06-28 15:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (657.29 KB, application/zip) 2013-06-28 20:12 PDT, Build Bot	no flags	Details
Patch V10 (31.18 KB, patch) 2013-06-28 23:30 PDT, Frédéric Wang (:fredw)	cfleizach: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch Final Version (31.14 KB, patch) 2013-06-30 02:08 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2013-05-06 06:57:44 PDT

Just FYI, I started to work on this today. It looks like a parsing function like http://mxr.mozilla.org/mozilla-central/source/content/mathml/content/src/nsMathMLElement.cpp#310 will be necessary. This is already needed for mfrac.

Frédéric Wang (:fredw)

Comment 2 2013-05-16 15:02:57 PDT

Created attachment 201993 [details] WIP Patch Experimental support for the mspace element. I guess negative spacing will not be considered in this bug, as that will require special layout of elements not available in CSS. Currently, there are hard coded default values width=30px, height=10px and depth=20px but it's just to verify that the patch works correctly. As said in comment 1, a parsing function is necessary for MathML length (similar to CSS values, but with some differences): http://www.w3.org/TR/MathML/chapter2.html#type.length I'm not familiar with WebKit String manipulation or Style structures, so I'll need some help to implement such a parsing function properly.

Frédéric Wang (:fredw)

Comment 3 2013-05-17 10:45:38 PDT

Created attachment 202118 [details] Patch V2 OK, I added a parsing function for MathML Length, similar to the one in Gecko and I used that to parse the mspace attributes (and mfrac@linethickness). For the moment, unitless, % and px values should work, but I'm still not quite sure about how to handle the other CSS units. @Martin: Any idea about how to convert the other CSS units to pixels? I tried things with style()->fontMetrics().xHeight(), style()->font().spaceWidth() or even style()->fontMetrics().unitsPerEm(), but that does not seem to work very well. There are probably functions in Webkit to do that conversion?

Frédéric Wang (:fredw)

Comment 4 2013-05-18 06:17:16 PDT

> @Martin: Any idea about how to convert the other CSS units to pixels? Never mind, I think I figured it out. I'll come back when I have tests.

Frédéric Wang (:fredw)

Comment 5 2013-05-18 07:31:18 PDT

Created attachment 202203 [details] Patch V3 Additional note: I did as in Gecko and provided separate ParseNumericValue and ParseNamedSpaceValue functions. IIRC, mpadded attribute parsing is a bit different and it was convenient to have separate functions.

EFL EWS Bot

Comment 6 2013-05-18 07:36:32 PDT

Comment on attachment 202203 [details] Patch V3 Attachment 202203 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/498295

EFL EWS Bot

Comment 7 2013-05-18 07:37:15 PDT

Comment on attachment 202203 [details] Patch V3 Attachment 202203 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/491715

Frédéric Wang (:fredw)

Comment 8 2013-05-18 07:48:11 PDT

Oops, I think I forgot to edit Source/WebCore/WebCore.vcproj/WebCore.vcproj...

Build Bot

Comment 9 2013-05-18 07:51:25 PDT

Comment on attachment 202203 [details] Patch V3 Attachment 202203 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/493650

Build Bot

Comment 10 2013-05-18 07:55:26 PDT

Comment on attachment 202203 [details] Patch V3 Attachment 202203 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/495679

Build Bot

Comment 11 2013-05-18 08:08:35 PDT

Comment on attachment 202203 [details] Patch V3 Attachment 202203 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/494688

Frédéric Wang (:fredw)

Comment 12 2013-05-18 08:17:59 PDT

Created attachment 202204 [details] Patch V4

Build Bot

Comment 13 2013-05-18 08:20:53 PDT

Comment on attachment 202204 [details] Patch V4 Attachment 202204 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/497395

EFL EWS Bot

Comment 14 2013-05-18 08:22:43 PDT

Comment on attachment 202204 [details] Patch V4 Attachment 202204 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/490748

EFL EWS Bot

Comment 15 2013-05-18 08:23:56 PDT

Comment on attachment 202204 [details] Patch V4 Attachment 202204 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/494693

Build Bot

Comment 16 2013-05-18 08:43:14 PDT

Comment on attachment 202204 [details] Patch V4 Attachment 202204 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/493661

Build Bot

Comment 17 2013-05-18 08:52:38 PDT

Comment on attachment 202204 [details] Patch V4 Attachment 202204 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/495684

Frédéric Wang (:fredw)

Comment 18 2013-05-18 12:25:22 PDT

Created attachment 202212 [details] Patch V5

EFL EWS Bot

Comment 19 2013-05-18 12:31:26 PDT

Comment on attachment 202212 [details] Patch V5 Attachment 202212 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/492774

EFL EWS Bot

Comment 20 2013-05-18 12:31:34 PDT

Comment on attachment 202212 [details] Patch V5 Attachment 202212 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/500257

Build Bot

Comment 21 2013-05-18 12:44:39 PDT

Comment on attachment 202212 [details] Patch V5 Attachment 202212 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/493719

Build Bot

Comment 22 2013-05-18 12:55:38 PDT

Comment on attachment 202212 [details] Patch V5 Attachment 202212 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/488885

Build Bot

Comment 23 2013-05-18 13:02:31 PDT

Comment on attachment 202212 [details] Patch V5 Attachment 202212 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/493720

Frédéric Wang (:fredw)

Comment 24 2013-05-21 00:36:04 PDT

Created attachment 202388 [details] Patch V5 - bis

EFL EWS Bot

Comment 25 2013-05-21 00:41:02 PDT

Comment on attachment 202388 [details] Patch V5 - bis Attachment 202388 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/422172

EFL EWS Bot

Comment 26 2013-05-21 00:42:05 PDT

Comment on attachment 202388 [details] Patch V5 - bis Attachment 202388 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/524141

Build Bot

Comment 27 2013-05-21 01:01:35 PDT

Comment on attachment 202388 [details] Patch V5 - bis Attachment 202388 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/527099

Build Bot

Comment 28 2013-05-21 01:02:51 PDT

Comment on attachment 202388 [details] Patch V5 - bis Attachment 202388 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/525126

Build Bot

Comment 29 2013-05-21 01:16:19 PDT

Comment on attachment 202388 [details] Patch V5 - bis Attachment 202388 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/498686

Frédéric Wang (:fredw)

Comment 30 2013-05-22 12:34:23 PDT

Created attachment 202612 [details] Patch V5 - try to build again

Build Bot

Comment 31 2013-05-22 12:44:09 PDT

Comment on attachment 202612 [details] Patch V5 - try to build again Attachment 202612 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/582001

Build Bot

Comment 32 2013-05-22 12:51:35 PDT

Comment on attachment 202612 [details] Patch V5 - try to build again Attachment 202612 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/559009

Build Bot

Comment 33 2013-05-22 13:00:01 PDT

Comment on attachment 202612 [details] Patch V5 - try to build again Attachment 202612 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/579001

Frédéric Wang (:fredw)

Comment 34 2013-05-23 11:30:14 PDT

So it seems the latest version builds on everything but Mac/Windows. Martin, can you please try to edit the XCode files with your Mac? -- Dave just mentioned the following code in mathml.css mspace[linebreak="newline"] { display: block; } that used to be used to create a newline but no longer works with the flex boxes. So that can be removed (the attribute is deprecated in MathML BTW ; line breaking is done on mo operators in MathML3)

Martin Robinson

Comment 35 2013-06-04 14:11:59 PDT

Here's the error on Windows: 7>WebCore.lib(MathMLAllInOne.obj) : error LNK2019: unresolved external symbol "public: __thiscall WebCore::RenderMathMLSpace::RenderMathMLSpace(class WebCore::Element *)" (??0RenderMathMLSpace@WebCore@@QAE@PAVElement@1@@Z) referenced in function "private: virtual class WebCore::RenderObject * __thiscall WebCore::MathMLTextElement::createRenderer(class WebCore::RenderArena *,class WebCore::RenderStyle *)" (?createRenderer@MathMLTextElement@WebCore@@EAEPAVRenderObject@2@PAVRenderArena@2@PAVRenderStyle@2@@Z) 7>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals Perhaps you need to add the new file to the MathMLAllInOne.cpp file?

Martin Robinson

Comment 36 2013-06-04 14:12:40 PDT

It seems you also removed something that looks like a BOM from the beginning of the file. I'm not sure if that's important or not...

Martin Robinson

Comment 37 2013-06-04 14:17:05 PDT

I cannot see anything immediately wrong with the additional lines in the XCode file, but you might try running xcodebodge and see if it produces something noticeably different: http://svn.jacekowski.org/chromium/trunk/tools/xcodebodge/xcodebodge.py

Frédéric Wang (:fredw)

Comment 38 2013-06-04 15:08:26 PDT

Created attachment 203729 [details] Patch V5 - ter > Perhaps you need to add the new file to the MathMLAllInOne.cpp file? I doubt this is the problem. The new files are for the mspace element and are in rendering/ while MathMLAllInOne does not contain any reference for other elements (mfrac, mfenced, msqrt etc). > It seems you also removed something that looks like a BOM from the beginning of the file. I'm not sure if that's important or not... That could well be the issue. I just refreshed the patch and will try again without this modification. If that does not work I'll try the Python script later.

Build Bot

Comment 39 2013-06-04 15:34:17 PDT

Comment on attachment 203729 [details] Patch V5 - ter Attachment 203729 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/711501

Build Bot

Comment 40 2013-06-04 15:40:32 PDT

Comment on attachment 203729 [details] Patch V5 - ter Attachment 203729 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/673572

Build Bot

Comment 41 2013-06-04 15:43:10 PDT

Comment on attachment 203729 [details] Patch V5 - ter Attachment 203729 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/714560

Frédéric Wang (:fredw)

Comment 42 2013-06-05 00:17:24 PDT

Created attachment 203758 [details] Patch V5 - quater

chris fleizach

Comment 43 2013-06-19 14:00:55 PDT

Comment on attachment 203758 [details] Patch V5 - quater View in context: https://bugs.webkit.org/attachment.cgi?id=203758&action=review You should separate the value parsing from the MathMLSpace patch into two patch I think, so you can address the line thickness issue separately. Thanks > LayoutTests/mathml/presentation/mfrac-linethickness-expected-mismatch.html:4 > + <title>mfrac linethickness</title> what is this testing? there's nothing related to mfrac in here > LayoutTests/mathml/presentation/mspace-expected.html:1 > +<!DOCTYPE html> Your layout tests probably shouldn't be suffixed with -expected, because that's the suffix for the expected results. I also don't see any results from running these layout tests... > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:-1 > -ï»¿<?xml version="1.0" encoding="utf-8"?> inccorrect addition here? > Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:317 > + return false; It seems a shame this is specific to MathML and not re-usable. I see code in CSSPrimitiveValue that handles some of these cases it appears > Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:322 > + int i = 0; you should choose a better name for this variable, plus it looks like it should be a float anyway

Frédéric Wang (:fredw)

Comment 44 2013-06-19 14:21:42 PDT

(In reply to comment #43) > You should separate the value parsing from the MathMLSpace patch into two patch I think, so you can address the line thickness issue separately. Yes that's probably what I'll do once MathJax 2.3 (hopefully this summer) is released and I can work on WebKit MathML again. Thanks for the review! > > Thanks > > > LayoutTests/mathml/presentation/mfrac-linethickness-expected-mismatch.html:4 > > + <title>mfrac linethickness</title> > > what is this testing? there's nothing related to mfrac in here This is a != reftest as indicated by the "expected-mismatch" suffix. The explanation is in the corresponding test LayoutTests/mathml/presentation/mfrac-linethickness.html > > > LayoutTests/mathml/presentation/mspace-expected.html:1 > > +<!DOCTYPE html> > > Your layout tests probably shouldn't be suffixed with -expected, because that's the suffix for the expected results. Not sure what you mean... That's a == reftest to compare with LayoutTests/mathml/presentation/mspace.html so the -expected suffix is necessary? > > I also don't see any results from running these layout tests... > > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:-1 > > -ï»¿<?xml version="1.0" encoding="utf-8"?> > > inccorrect addition here? Ooops, I thought I had fixed that one. > > > Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:317 > > + return false; > > It seems a shame this is specific to MathML and not re-usable. I see code in CSSPrimitiveValue that handles some of these cases it appears That's what I asked above but couldn't find these CSS primitive alone. However some work is needed to parse the MathML-specific stuff like the unitless case you implemented, so a separate function is necessary anyway. Note that using a MathML-specific routine is also what Gecko does. > > > Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:322 > > + int i = 0; > > you should choose a better name for this variable, plus it looks like it should be a float anyway True. (I just copied that from the Gecko code...)

Frédéric Wang (:fredw)

Comment 45 2013-06-19 14:26:29 PDT

Just to be sure we agree, here is the document I read about WebKit convention regarding reftests: http://trac.webkit.org/wiki/Writing%20Reftests

Frédéric Wang (:fredw)

Comment 46 2013-06-26 09:56:25 PDT

Created attachment 205506 [details] Patch V6

EFL EWS Bot

Comment 47 2013-06-26 10:02:49 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/967343

Build Bot

Comment 48 2013-06-26 10:03:29 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/916719

EFL EWS Bot

Comment 49 2013-06-26 10:03:42 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/919270

kov's GTK+ EWS bot

Comment 50 2013-06-26 10:04:00 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/946382

Build Bot

Comment 51 2013-06-26 10:21:15 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/978824

Build Bot

Comment 52 2013-06-26 14:16:51 PDT

Comment on attachment 205506 [details] Patch V6 Attachment 205506 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/901226

Frédéric Wang (:fredw)

Comment 53 2013-06-28 10:13:31 PDT

Created attachment 205723 [details] Patch V7 Some remarks: - Dynamically changes via Javascript does not seem to work. That seems to be a general issue in WebKit MathML (e.g. with linethickness), so that should better be fixed in a separate bug. - The parsing of pt and pc was broken when I replaced float constants by integers in the MathML length patch. This is fixed and tested here. - I had hard time to edit the XCode make file by hand and finally tried a Python script suggested by Martin. However, the changes do not seem really consistent with the existing source code so I'd appreciate if someone with a Mac can edit that file with XCode.

chris fleizach

Comment 54 2013-06-28 10:58:44 PDT

Comment on attachment 205723 [details] Patch V7 View in context: https://bugs.webkit.org/attachment.cgi?id=205723&action=review > Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:299 > + lengthValue = 4 * floatValue / 3; use parenthesis to make it clear what the order of operations are > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:30 > +#include "RenderMathMLSpace.h" this should go right below config > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:48 > +bool RenderMathMLSpace::isChildAllowed(RenderObject*, RenderStyle*) const this can be put in the header > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:57 > + m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth = m_width; don't do cascading equals. put on separate line > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:67 > + m_width = m_height = m_depth = 0; ditto about equals > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:73 > + if (m_width <= 0) this should just be m_width < 0 > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:77 > + if (m_height + m_depth <= 0) < 0 instead of <= 0. I would also add parens > Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:78 > + m_height = m_depth = 0; ditto about the equals > Source/WebCore/rendering/mathml/RenderMathMLSpace.h:37 > + RenderMathMLSpace(Element*); explicit needed before the constructor > Source/WebCore/rendering/mathml/RenderMathMLSpace.h:43 > + virtual void updateFromElement(); are these also OVERRIDES? can all these virtual methods move into private space

Frédéric Wang (:fredw)

Comment 55 2013-06-28 12:33:19 PDT

Created attachment 205733 [details] Patch V8

Build Bot

Comment 56 2013-06-28 13:43:38 PDT

Comment on attachment 205733 [details] Patch V8 Attachment 205733 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/987486 New failing tests: mathml/presentation/mspace-units.html

Build Bot

Comment 57 2013-06-28 13:43:44 PDT

Created attachment 205740 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Frédéric Wang (:fredw)

Comment 58 2013-06-28 13:59:38 PDT

Created attachment 205741 [details] Patch V9 It seems that there is a small pixel failure in Mac due to rounding errors. Trying again with a modified length computation.

Build Bot

Comment 59 2013-06-28 15:50:22 PDT

Comment on attachment 205741 [details] Patch V9 Attachment 205741 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/981846 New failing tests: mathml/presentation/mspace-units.html

Build Bot

Comment 60 2013-06-28 15:50:27 PDT

Created attachment 205751 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Build Bot

Comment 61 2013-06-28 20:12:45 PDT

Comment on attachment 205741 [details] Patch V9 Attachment 205741 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/913443 New failing tests: mathml/presentation/mspace-units.html svg/batik/filters/feTile.svg

Build Bot

Comment 62 2013-06-28 20:12:53 PDT

Created attachment 205762 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Frédéric Wang (:fredw)

Comment 63 2013-06-28 23:30:30 PDT

Created attachment 205764 [details] Patch V10

WebKit Commit Bot

Comment 64 2013-06-30 01:14:53 PDT

Comment on attachment 205764 [details] Patch V10 Rejecting attachment 205764 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 205764, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/860684

Frédéric Wang (:fredw)

Comment 65 2013-06-30 02:08:18 PDT

Created attachment 205774 [details] Patch Final Version

WebKit Commit Bot

Comment 66 2013-06-30 03:09:05 PDT

Comment on attachment 205774 [details] Patch Final Version Rejecting attachment 205774 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 205774, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ubmit return self.open(self.click(*args, **kwds)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-queues.appspot.com/results/887325

Frédéric Wang (:fredw)

Comment 67 2013-07-01 11:20:03 PDT

Comment on attachment 205774 [details] Patch Final Version Not sure why the commit failed. Apparently everything is green, so that seemed to be an infrastructure problem.

WebKit Commit Bot

Comment 68 2013-07-01 11:42:21 PDT

Comment on attachment 205774 [details] Patch Final Version Clearing flags on attachment: 205774 Committed r152235: <http://trac.webkit.org/changeset/152235>

WebKit Commit Bot

Comment 69 2013-07-01 11:42:29 PDT

All reviewed patches have been landed. Closing bug.

Andreas Kling

Comment 70 2013-07-02 05:49:56 PDT

This caused some failures on debug bots: https://bugs.webkit.org/show_bug.cgi?id=118298

Alexey Proskuryakov

Comment 71 2014-01-14 12:33:24 PST

Testing bugzilla reopen functionality, sorry for the noise.

Frédéric Wang (:fredw)

Comment 72 2014-03-10 12:25:56 PDT

Mass change: add WebExposed keyword to help MDN documentation.

Note You need to log in before you can comment on or make changes to this bug.