Bug 115511

Summary: [Qt] REGRESSION(r149457): some fast/exclusions tests are failing
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: Tools / TestsAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, giles_joplin, jturcotte, kadam, krit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79666, 115455    
Attachments:
Description Flags
Patch
kling: review-
Patch none

Zoltan Arvai
Reported 2013-05-02 04:35:37 PDT
Four test failing on Qt: fast/exclusions/shape-inside/shape-inside-polygon-layout.html fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html On Qt sub-pixel layout is enabled (except Qt Mac).
Attachments
Patch (970 bytes, patch)
2013-05-17 16:10 PDT, Hans Muller 		kling: review-
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2013-05-20 08:19 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2013-05-02 05:14:00 PDT
Skipped on Qt in http://trac.webkit.org/changeset/149484. Please unskip it when it fixed.
Hans Muller
Comment 2 2013-05-17 16:10:08 PDT
Created attachment 202170 [details] Patch Unskipping the exclusions tests. There were fixed by https://bugs.webkit.org/show_bug.cgi?id=116115. Thanks for Zoltan Horvath for checking the patch against a Qt build.
Andreas Kling
Comment 3 2013-05-17 16:16:27 PDT
Comment on attachment 202170 [details] Patch Needs more ChangeLog.
Hans Muller
Comment 4 2013-05-20 08:19:46 PDT
Created attachment 202278 [details] Patch Added the ChangeLog (sorry about that). This bug's ID# is a palindrome.
WebKit Commit Bot
Comment 5 2013-05-20 13:00:29 PDT
Comment on attachment 202278 [details] Patch Clearing flags on attachment: 202278 Committed r150378: <http://trac.webkit.org/changeset/150378>
WebKit Commit Bot
Comment 6 2013-05-20 13:00:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.