Bug 114930

Summary: fourthTier: FTL should call LLVMFinalizeAllObjects()
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch
none
corresponding llvm patch none

Filip Pizlo
Reported 2013-04-21 19:05:46 PDT
This is needed for the corresponding MCJIT llvm-c patch I'm submitting to llvm-commits.
Attachments
the patch (1.60 KB, patch)
2013-04-21 19:07 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
corresponding llvm patch (6.04 KB, patch)
2013-04-21 19:08 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-04-21 19:07:30 PDT
Created attachment 198980 [details] the patch I will wait with landing this until there is a clear story for my llvm-c patch.
Filip Pizlo
Comment 2 2013-04-21 19:08:34 PDT
Created attachment 198981 [details] corresponding llvm patch
Filip Pizlo
Comment 3 2013-04-22 15:00:21 PDT
Comment on attachment 198980 [details] the patch It looks like LLVMFinalizeAllObjects() is not going to be a thing. Clearing r?.
Filip Pizlo
Comment 4 2013-04-22 15:01:22 PDT
It looks like this is again taking a different direction; this time, the LLVM C API will ensure that the MCJIT finalizes all objects before you use them. I'm leaving this bug open for now in case this again changes, but probably this will get resolved as wontfix.
Filip Pizlo
Comment 5 2013-04-29 21:51:00 PDT
Nope, it looks like LLVM isn't going to require this.
Note You need to log in before you can comment on or make changes to this bug.