Bug 113660

Summary: build-webkit doesn't support some build options
Product: WebKit Reporter: Ed Bartosh <bartosh>
Component: Tools / TestsAssignee: Ed Bartosh <bartosh>
Status: UNCONFIRMED    
Severity: Normal CC: cdumez, dbates, eduk750, gtk-ews, gyuyoung.kim, kalyan.kondapally, laszlo.gombos, mifenton, philn, rakuco, rego+ews, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 113641, 113951, 114089, 114299    
Bug Blocks:    
Attachments:
Description Flags
Patch
eflews.bot: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
eflews.bot: commit-queue-
Patch
none
Patch
eflews.bot: commit-queue-
Patch
eflews.bot: commit-queue-
Patch
eflews.bot: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch gtk-ews: commit-queue-

Ed Bartosh
Reported 2013-03-31 08:21:48 PDT
Below is the list of build options from WebkitFeatures.cmake, which are not supported by webkit build(not present in FeatureList.pm): ENABLE_ACCESSIBILITY ENABLE_API_TESTS ENABLE_ASSEMBLER_WX_EXCLUSIVE ENABLE_DRAG_SUPPORT ENABLE_ENABLE_MOUSE_CURSOR_SCALE ENABLE_FAST_MOBILE_SCROLLING ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING ENABLE_IMAGE_DECODER_DOWN_SAMPLING ENABLE_JIT ENABLE_LEGACY_VIEWPORT_ADAPTION ENABLE_LLINT ENABLE_MEMORY_SAMPLER ENABLE_PLUGIN_PROXY_FOR_VIDEO ENABLE_REPAINT_THROTTLING ENABLE_SPELLCHECK ENABLE_VIEW_MODE_CSS_MEDIA
Attachments
Patch (11.22 KB, patch)
2013-03-31 10:08 PDT, Ed Bartosh 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (11.12 KB, patch)
2013-03-31 11:09 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (10.47 KB, patch)
2013-03-31 12:00 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (12.45 KB, patch)
2013-03-31 12:31 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (13.26 KB, patch)
2013-03-31 12:46 PDT, Ed Bartosh 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (14.01 KB, patch)
2013-03-31 13:17 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (17.77 KB, patch)
2013-03-31 13:39 PDT, Ed Bartosh 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (17.17 KB, patch)
2013-03-31 16:18 PDT, Ed Bartosh 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (9.93 KB, patch)
2013-04-01 01:20 PDT, Ed Bartosh 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (10.60 KB, patch)
2013-04-06 03:26 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (11.26 KB, patch)
2013-04-08 12:19 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (11.29 KB, patch)
2013-04-09 10:39 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (11.25 KB, patch)
2013-05-09 06:35 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (11.56 KB, patch)
2013-05-11 14:01 PDT, Ed Bartosh 		gtk-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.
Ed Bartosh
Comment 1 2013-03-31 10:08:35 PDT
Created attachment 195897 [details] Patch
EFL EWS Bot
Comment 2 2013-03-31 10:41:35 PDT
Comment on attachment 195897 [details] Patch Attachment 195897 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17328596
kov's GTK+ EWS bot
Comment 3 2013-03-31 11:06:41 PDT
Comment on attachment 195897 [details] Patch Attachment 195897 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17337421
Ed Bartosh
Comment 4 2013-03-31 11:09:44 PDT
Created attachment 195899 [details] Patch
Ed Bartosh
Comment 5 2013-03-31 12:00:22 PDT
Created attachment 195901 [details] Patch
EFL EWS Bot
Comment 6 2013-03-31 12:13:51 PDT
Comment on attachment 195901 [details] Patch Attachment 195901 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17344248
Ed Bartosh
Comment 7 2013-03-31 12:31:16 PDT
Created attachment 195902 [details] Patch
Ed Bartosh
Comment 8 2013-03-31 12:46:01 PDT
Created attachment 195903 [details] Patch
EFL EWS Bot
Comment 9 2013-03-31 13:04:51 PDT
Comment on attachment 195903 [details] Patch Attachment 195903 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17293477
Ed Bartosh
Comment 10 2013-03-31 13:17:12 PDT
Created attachment 195905 [details] Patch
EFL EWS Bot
Comment 11 2013-03-31 13:30:41 PDT
Comment on attachment 195905 [details] Patch Attachment 195905 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17382120
Ed Bartosh
Comment 12 2013-03-31 13:39:56 PDT
Created attachment 195906 [details] Patch
EFL EWS Bot
Comment 13 2013-03-31 13:55:10 PDT
Comment on attachment 195906 [details] Patch Attachment 195906 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17340917
kov's GTK+ EWS bot
Comment 14 2013-03-31 14:34:59 PDT
Comment on attachment 195906 [details] Patch Attachment 195906 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17240731
Ed Bartosh
Comment 15 2013-03-31 16:18:47 PDT
Created attachment 195908 [details] Patch
WebKit Review Bot
Comment 16 2013-03-31 16:20:33 PDT
Attachment 195908 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/atk/FrameSelectionAtk.cpp', u'Source/WebCore/page/gtk/EventHandlerGtk.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/AccessibilityUIElement.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1 Tools/DumpRenderTree/AccessibilityUIElement.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 17 2013-03-31 16:54:22 PDT
Comment on attachment 195908 [details] Patch Attachment 195908 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17325413
Ed Bartosh
Comment 18 2013-04-01 01:10:58 PDT
Added dependency to 113641. I'll move all build fixes there or to new bugs.
Ed Bartosh
Comment 19 2013-04-01 01:20:39 PDT
Created attachment 195941 [details] Patch Removed all build fixes from the patch. Fixes will be added to dependent bugs.
EFL EWS Bot
Comment 20 2013-04-02 12:31:09 PDT
Comment on attachment 195941 [details] Patch Attachment 195941 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17314748
Ed Bartosh
Comment 21 2013-04-06 03:26:15 PDT
Created attachment 196728 [details] Patch
EFL EWS Bot
Comment 22 2013-04-06 04:04:57 PDT
Comment on attachment 196728 [details] Patch Attachment 196728 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17526330
Ed Bartosh
Comment 23 2013-04-08 12:19:53 PDT
Created attachment 196882 [details] Patch
EFL EWS Bot
Comment 24 2013-04-08 13:07:59 PDT
Comment on attachment 196882 [details] Patch Attachment 196882 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17562026
kov's GTK+ EWS bot
Comment 25 2013-04-08 14:15:15 PDT
Comment on attachment 196882 [details] Patch Attachment 196882 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17490054
Ed Bartosh
Comment 26 2013-04-09 10:39:42 PDT
Created attachment 197144 [details] Patch
kov's GTK+ EWS bot
Comment 27 2013-04-09 11:34:31 PDT
Comment on attachment 197144 [details] Patch Attachment 197144 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17676041
Ryosuke Niwa
Comment 28 2013-04-10 18:18:43 PDT
Comment on attachment 197144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197144&action=review > Tools/Scripts/webkitperl/FeatureList.pm:524 > + { option => "view-mode-css-media", desc => "Toggle Track support for the view-mode media Feature support", > + define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport }, Why is this default 1? I don't think Mac enables this feature by default. r-.
Ed Bartosh
Comment 29 2013-04-29 10:39:42 PDT
I took default values of all options from Source/cmake/WebKitFeatures.cmake. By default ENABLE_VIEW_MODE_CSS_MEDIA is enabled there: WEBKIT_OPTION_DEFINE(ENABLE_VIEW_MODE_CSS_MEDIA "Toggle Track support for the view-mode media Feature" ON)
Ed Bartosh
Comment 30 2013-05-09 06:35:07 PDT
Created attachment 201186 [details] Patch
Chris Dumez
Comment 31 2013-05-09 06:43:24 PDT
Comment on attachment 201186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201186&action=review > Tools/Scripts/webkitperl/FeatureList.pm:525 > + define => "ENABLE_VIEW_MODE_CSS_MEDIA", default => 1, value => \$viewModeCssMediaSupport }, You did not take rniwa's feedback into consideration. As far as I know, EFL, BlackBerry and GTK and the only ports enabling this. This should therefore probably be (isEfl() || isGtk() || isBlackBerry()) instead of 1. You need to do similar checks for all the features or you are likely to break other ports. Not all the ports are using CMake and even those using CMake may override the default valye in WebKitFeatures.cmake.
Ed Bartosh
Comment 32 2013-05-09 07:55:16 PDT
Christophe, thank you for the explanations. Now I started to understand where I'm wrong with this patch. I was actually taking Niwa's comment into consideration, but didn't understand the whole thing. I've submitted patch again just to see where it'll break the build.
kov's GTK+ EWS bot
Comment 33 2013-05-09 09:05:01 PDT
Comment on attachment 201186 [details] Patch Attachment 201186 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/277084
Ed Bartosh
Comment 34 2013-05-09 14:03:12 PDT
Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me.
Chris Dumez
Comment 35 2013-05-09 14:11:50 PDT
(In reply to comment #34) > Christophe, can you please explain where can I check default build options for different platforms? It's still unclear to me. I work mostly on EFL port so this is not 100% clear for me either. My current guess is: - mac: Source/WebCore/Configurations/FeatureDefines.xcconfig - EFL: Source/cmake/OptionsEfl.cmake -> Source/cmake/WebKitFeatures.cmake - BlackBerry: Source/cmake/OptionsBlackBerry.cmake -> Source/cmake/WebKitFeatures.cmake - GTK: Source/autotools/SetupWebKitFeatures.m4 - Qt: I think it is using build-webkit only
Ed Bartosh
Comment 36 2013-05-11 14:01:22 PDT
Created attachment 201471 [details] Patch
Ed Bartosh
Comment 37 2013-05-11 14:02:57 PDT
Christophe, thank you! I looked into all those files and set up defaults accordingly.
kov's GTK+ EWS bot
Comment 38 2013-05-11 15:08:34 PDT
Comment on attachment 201471 [details] Patch Attachment 201471 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/375257
Note You need to log in before you can comment on or make changes to this bug.