Bug 113394

Summary:

Add support for runtime flags for experimental blending to chromium

Product:

WebKit

Reporter:

Rik Cabanier <cabanier>

Component:

Platform

Assignee:

Mihai Tica <mitica>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

cabanier, eric, jamesr, schenney, syoichi

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

108550

Attachments:

Description	Flags
Patch	none

Rik Cabanier

Reported 2013-03-27 05:11:47 PDT

Add the option to enable blending CSS features to chromium through chrome://flags/

Attachments
Patch (1.35 KB, patch) 2013-03-27 06:48 PDT, Mihai Tica	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihai Tica

Comment 1 2013-03-27 06:48:21 PDT

Created attachment 195305 [details] Patch

Rik Cabanier

Comment 2 2013-03-27 07:37:06 PDT

The CSS_COMPOSITING flag enables the parsing of the blend CSS keywords. By default, those functions are turned off. Only when the flag for experimental features is enabled, will the css keywords be parsed.

James Robinson

Comment 3 2013-03-28 14:12:44 PDT

Comment on attachment 195305 [details] Patch This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger

Eric Seidel (no email)

Comment 4 2013-03-28 14:16:22 PDT

I must be searching wrong. I only see this controlling parsing? https://code.google.com/p/chromium/codesearch#search/&q=CSS_COMPOSITING&sq=package:chromium&type=cs

Mihai Tica

Comment 5 2013-03-28 14:20:47 PDT

As far as I know, indeed only the parsing bit is currently done for Chromium. I don't think the other changes under this flag impact the chromium port, as they seem WebKit specific.

Rik Cabanier

Comment 6 2013-03-28 14:23:00 PDT

(In reply to comment #4) > I must be searching wrong. I only see this controlling parsing? > https://code.google.com/p/chromium/codesearch#search/&q=CSS_COMPOSITING&sq=package:chromium&type=cs That is correct. We are still working on getting the actual rendering in. There are patches in the works.

Rik Cabanier

Comment 7 2013-03-28 14:38:52 PDT

(In reply to comment #3) > (From update of attachment 195305 [details]) > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. StyleRareNonInheritedData should not be *that* much bigger.

James Robinson

Comment 8 2013-03-29 09:57:05 PDT

(In reply to comment #7) > (In reply to comment #3) > > (From update of attachment 195305 [details] [details]) > > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger > > When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. > StyleRareNonInheritedData should not be *that* much bigger. OK, but that doesn't answer my question. Where are the runtime guards for this functionality?

Rik Cabanier

Comment 9 2013-03-29 10:56:42 PDT

(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #3) > > > (From update of attachment 195305 [details] [details] [details]) > > > This #define appears to control a lot of code in RenderLayer, RenderLayerBacking, etc. Where is the runtime guard for these features? It also does things like make StyleRareNonInheritedData bigger > > > > When I first added support, I had them all ifdef'ed. Simon Fraser told me to just put defines on the parsing side because he thought it was too messy. > > StyleRareNonInheritedData should not be *that* much bigger. > > OK, but that doesn't answer my question. Where are the runtime guards for this functionality? ah, I was replying to making StyleRareNonInheritedData bigger. see https://bugs.webkit.org/show_bug.cgi?id=111818 for the runtime hooks.

Ryosuke Niwa

Comment 10 2013-04-10 18:11:14 PDT

Comment on attachment 195305 [details] Patch Clearing the flag.

Note You need to log in before you can comment on or make changes to this bug.