Bug 113327

Summary: Web Inspector: Exception in console on attempt to filter javascript messages.
Product: WebKit Reporter: Dmitry Zvorygin <zvorygin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dmitry Zvorygin
Reported 2013-03-26 11:11:47 PDT
Exception in console on attempt to filter javascript messages by source if console groups are used.
Attachments
Patch (8.43 KB, patch)
2013-03-26 11:38 PDT, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (19.89 KB, patch)
2013-03-27 07:28 PDT, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2013-04-01 07:24 PDT, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry Zvorygin
Comment 1 2013-03-26 11:38:23 PDT
Created attachment 195127 [details] Patch
Pavel Feldman
Comment 2 2013-03-27 03:13:28 PDT
Comment on attachment 195127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195127&action=review > Source/WebCore/inspector/front-end/ConsoleMessage.js:779 > + if (!this._element) return; return should be on the next line > Source/WebCore/inspector/front-end/ConsoleView.js:559 > + } else if (sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroup || sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed) { This needs a test > Source/WebCore/inspector/front-end/ConsoleView.js:673 > + this._messages.push(message); Let migrate tests back to this._messages
Dmitry Zvorygin
Comment 3 2013-03-27 07:28:07 PDT
Created attachment 195315 [details] Patch
Dmitry Zvorygin
Comment 4 2013-03-27 07:36:06 PDT
Comment on attachment 195127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195127&action=review >> Source/WebCore/inspector/front-end/ConsoleMessage.js:779 >> + if (!this._element) return; > > return should be on the next line Done. >> Source/WebCore/inspector/front-end/ConsoleView.js:559 >> + } else if (sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroup || sourceMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed) { > > This needs a test Added tests. >> Source/WebCore/inspector/front-end/ConsoleView.js:673 >> + this._messages.push(message); > > Let migrate tests back to this._messages Tests shouldn't use _messages field, but instead use DOM generated by console.
Pavel Feldman
Comment 5 2013-03-28 05:26:31 PDT
Comment on attachment 195315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195315&action=review > LayoutTests/inspector/console/console-filter-test.html:17 > + log1(i + "topGroup"); // from console-filter-test.html Please don't change the tests when doing refactorings - it is hard to spot the regression and merge if necessary.
Dmitry Zvorygin
Comment 6 2013-03-28 05:55:02 PDT
Comment on attachment 195315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195315&action=review >> LayoutTests/inspector/console/console-filter-test.html:17 >> + log1(i + "topGroup"); // from console-filter-test.html > > Please don't change the tests when doing refactorings - it is hard to spot the regression and merge if necessary. That's the test which I wrote, and which originally worked fine(before and after refactoring). I just made this test to cover additional group-related cases.
Dmitry Zvorygin
Comment 7 2013-04-01 07:24:37 PDT
Created attachment 195966 [details] Patch
WebKit Review Bot
Comment 8 2013-04-01 08:23:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 195966 [details]: fast/preloader/document-write-noscript.html bug 113464 (authors: rniwa@webkit.org and tonyg@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 9 2013-04-01 08:25:06 PDT
Comment on attachment 195966 [details] Patch Clearing flags on attachment: 195966 Committed r147327: <http://trac.webkit.org/changeset/147327>
WebKit Review Bot
Comment 10 2013-04-01 08:25:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.