Bug 113298

Summary: Move remaining marquee applying code to StyleBuilder
Product: WebKit Reporter: Emil A Eklund <eae>
Component: CSSAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, eric, esprehn+autocc, macpherson, menard, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2013-03-26 05:16:49 PDT
Move applying logic for CSSPropertyWebkitMarqueeIncrement, CSSPropertyWebkitMarqueeRepetition and CSSPropertyWebkitMarqueeSpeed from StyleResolver::applyProperty.
Attachments
Patch (11.75 KB, patch)
2013-03-26 05:20 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2013-03-26 05:20:12 PDT
Created attachment 195062 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-03-28 06:14:13 PDT
Comment on attachment 195062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review r=me, assuming we have layout tests of marquee CSS. > Source/WebCore/ChangeLog:12 > + No new tests, no change in functionality. Do we have tests testing marquee CSS? If not we should add some.
Emil A Eklund
Comment 3 2013-04-01 12:24:11 PDT
(In reply to comment #2) > (From update of attachment 195062 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review > > r=me, assuming we have layout tests of marquee CSS. > > > Source/WebCore/ChangeLog:12 > > + No new tests, no change in functionality. > > Do we have tests testing marquee CSS? If not we should add some. We have a handful of tests for it, most notably fast/html/marquee-element.html and fast/css/MarqueeLayoutTest.html
WebKit Review Bot
Comment 4 2013-04-01 12:47:39 PDT
Comment on attachment 195062 [details] Patch Clearing flags on attachment: 195062 Committed r147350: <http://trac.webkit.org/changeset/147350>
WebKit Review Bot
Comment 5 2013-04-01 12:47:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.