Bug 112654

Summary: DFG ToString generic cases should work correctly
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
ggaren: review+
patch for landing none

Filip Pizlo
Reported 2013-03-18 21:12:15 PDT
I was forgetting to move the operand into the result if the operand was already a string. :-/ <rdar://problem/13447250>
Attachments
the patch (4.44 KB, patch)
2013-03-18 21:13 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
patch for landing (21.14 KB, patch)
2013-03-18 22:02 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-03-18 21:13:16 PDT
Created attachment 193721 [details] the patch
Filip Pizlo
Comment 2 2013-03-18 21:13:42 PDT
(In reply to comment #1) > Created an attachment (id=193721) [details] > the patch Note, I have two test cases that I'm almost done building.
Geoffrey Garen
Comment 3 2013-03-18 21:15:44 PDT
Comment on attachment 193721 [details] the patch r=me Can we regression test this?
Filip Pizlo
Comment 4 2013-03-18 21:17:19 PDT
(In reply to comment #3) > (From update of attachment 193721 [details]) > r=me > > Can we regression test this? Yes. I have two tests - one for the Cell case and the other for the Untyped case. Not done running tests yet so I didn't have -expected files at the time I uploaded the patch.
Filip Pizlo
Comment 5 2013-03-18 21:56:49 PDT
*** Bug 112656 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 6 2013-03-18 22:01:30 PDT
Confirmed that this patch fixes https://bugs.webkit.org/show_bug.cgi?id=112656.
Filip Pizlo
Comment 7 2013-03-18 22:02:10 PDT
Created attachment 193725 [details] patch for landing
Filip Pizlo
Comment 8 2013-03-18 22:26:30 PDT
Landed in http://trac.webkit.org/changeset/146179
Note You need to log in before you can comment on or make changes to this bug.