Bug 112574

Summary: [CSS Grid Layout] Fix StyleGridData::operator==
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, hans, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60731, 112501    
Attachments:
Description Flags
Trivial fix + test. none

Julien Chaffraix
Reported 2013-03-18 08:41:10 PDT
Super obvious bug: bool operator==(const StyleGridData& o) const { return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow != o.m_gridAutoFlow; }
Attachments
Trivial fix + test. (4.96 KB, patch)
2013-03-18 09:07 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-03-18 09:07:31 PDT
Created attachment 193575 [details] Trivial fix + test.
Julien Chaffraix
Comment 2 2013-03-18 11:47:55 PDT
Comment on attachment 193575 [details] Trivial fix + test. Mac passed the EWS, not sure why it's being picked again for testing.
WebKit Review Bot
Comment 3 2013-03-18 12:06:59 PDT
Comment on attachment 193575 [details] Trivial fix + test. Clearing flags on attachment: 193575 Committed r146098: <http://trac.webkit.org/changeset/146098>
WebKit Review Bot
Comment 4 2013-03-18 12:07:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.