Bug 112260

Summary: [Qt] Port DRT to use TestRunner::dumpAsText()
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: New BugsAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109677    
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Zeno Albisser
Reported 2013-03-13 08:01:47 PDT
[Qt] Port DRT to use TestRunner::dumpAsText()
Attachments
Patch (6.04 KB, patch)
2013-03-13 08:03 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Patch (6.13 KB, patch)
2013-03-13 08:32 PDT, Zeno Albisser 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2013-03-13 08:03:46 PDT
Created attachment 192923 [details] Patch
Simon Hausmann
Comment 2 2013-03-13 08:12:11 PDT
Comment on attachment 192923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192923&action=review > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:994 > - if (m_dumpPixelsForCurrentTest && m_controller->shouldDumpPixels()) { > + if (m_dumpPixelsForCurrentTest) { Shouldn't this use m_jscController->generatePixelResults() ? What do the other ports do there?
Zeno Albisser
Comment 3 2013-03-13 08:32:34 PDT
Created attachment 192928 [details] Patch
Benjamin Poulain
Comment 4 2013-03-13 22:57:48 PDT
Comment on attachment 192928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192928&action=review Looks reasonable. > Tools/ChangeLog:15 > + TestRunnerQt::shouldDumpPixels() always returned true > + in our case and can therefore be replaced with > + TestRunner::generatePixelResults(). I am a little confused by this sentence.
Zeno Albisser
Comment 5 2013-03-14 03:09:41 PDT
Committed r145800: <http://trac.webkit.org/changeset/145800>
Note You need to log in before you can comment on or make changes to this bug.