Bug 112001

Summary: [EFL] accessibility/ignore-spacer-elements.html is failing.
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, gyuyoung.kim, jdiggs, lucas.de.marchi, mario, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 111985    
Attachments:
Description Flags
Patch none

Krzysztof Czech
Reported 2013-03-11 07:21:57 PDT
accessibility/ignore-spacer-elements.html is failing on all EFL platforms.
Attachments
Patch (3.40 KB, patch)
2013-03-20 08:12 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2013-03-20 08:12:31 PDT
Created attachment 194063 [details] Patch
Mario Sanchez Prada
Comment 2 2013-03-21 03:21:45 PDT
Comment on attachment 194063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194063&action=review > LayoutTests/accessibility/ignore-spacer-elements.html:28 > + var expectedCount = (testRunner.platformName == "gtk" || testRunner.platformName == "efl") ? 2 : 4; I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. Thoughts?
Krzysztof Czech
Comment 3 2013-03-21 04:24:08 PDT
> I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. > > Thoughts? In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms.
Mario Sanchez Prada
Comment 4 2013-03-21 06:28:06 PDT
(In reply to comment #3) > > I wonder if it would make sense to change DRT to output "atk" for testRunner.platformName both in GTK and EFL ports, to reduce the amount of ORs like this one in layout tests. > > > > Thoughts? > In terms of accessibility layout tests it sounds good. I'm wondering about other tests and potential differences between platforms. Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think).
Krzysztof Czech
Comment 5 2013-03-28 08:46:22 PDT
> Ah, yes... you're right. I was thinking of this as an a11y-only feature of DRT, but it's true it's not like that, since is a general feature of testRunner (even though it's only used in a11y tests so far, I think). Yes, it's only used in a11y tests.
Gyuyoung Kim
Comment 6 2013-04-03 01:27:28 PDT
Comment on attachment 194063 [details] Patch rs=me
WebKit Review Bot
Comment 7 2013-04-03 02:47:39 PDT
Comment on attachment 194063 [details] Patch Clearing flags on attachment: 194063 Committed r147534: <http://trac.webkit.org/changeset/147534>
WebKit Review Bot
Comment 8 2013-04-03 02:47:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.