Bug 111423

Summary: CompactHTMLToken does not need an XSSInfo pointer
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, esprehn+autocc, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2013-03-05 04:49:33 PST
CompactHTMLToken does not need an XSSInfo pointer It appears the XSSInfo objects have nothing to do with the token? They could be held on the ParsedChunk in a side-vector and take up much less space. We could even associated them to a TokenIndex if that's important, but it doesn't seem to be from my reading of the code?
Attachments
Patch (11.18 KB, patch)
2013-03-05 11:51 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-03-05 09:37:27 PST
Yeah, they can probably move to the ParsedChunk.
Tony Gentilcore
Comment 2 2013-03-05 09:55:31 PST
Good catch. I can take care of this.
Tony Gentilcore
Comment 3 2013-03-05 11:51:33 PST
Created attachment 191528 [details] Patch
Eric Seidel (no email)
Comment 4 2013-03-05 12:04:06 PST
Comment on attachment 191528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:400 > + break; This will end up producing a slightly different tree than before. I'm not sure if that matters.
Tony Gentilcore
Comment 5 2013-03-05 12:07:58 PST
(In reply to comment #4) > (From update of attachment 191528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191528&action=review > > > Source/WebCore/html/parser/HTMLDocumentParser.cpp:400 > > + break; > > This will end up producing a slightly different tree than before. I'm not sure if that matters. Yes it will. Only in the case the entire page is blocked. And I don't think it matters in that case.
WebKit Review Bot
Comment 6 2013-03-05 12:46:39 PST
Comment on attachment 191528 [details] Patch Clearing flags on attachment: 191528 Committed r144801: <http://trac.webkit.org/changeset/144801>
WebKit Review Bot
Comment 7 2013-03-05 12:46:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.