Bug 111072

Created attachment 190722 [details] Patch

Attachment 190722 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp', u'Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.h', u'Source/WebCore/platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/DrawingBufferBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp', u'Source/WebCore/platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h', u'Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp', u'Source/WebCore/platform/graphics/blackberry/EGLImageLayerWebKitThread.h', u'Source/WebCore/platform/graphics/blackberry/FloatRectBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCacheBlackberry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformData.h', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GradientBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.h', u'Source/WebCore/platform/graphics/blackberry/ITypeUtils.h', u'Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBufferDataBlackBerry.h', u'Source/WebCore/platform/graphics/blackberry/InstrumentedPlatformCanvas.h', u'Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h', u'Source/WebCore/platform/graphics/blackberry/LayerCompositingThreadClient.h', u'Source/WebCore/platform/graphics/blackberry/LayerData.h', u'Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerRenderer.h', u'Source/WebCore/platform/graphics/blackberry/LayerRendererSurface.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerTile.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerTile.h', u'Source/WebCore/platform/graphics/blackberry/LayerTileIndex.h', u'Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerTiler.h', u'Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.cpp', u'Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.h', u'Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h', u'Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.h', u'Source/WebCore/platform/graphics/blackberry/PluginLayerWebKitThread.cpp', u'Source/WebCore/platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/Texture.cpp', u'Source/WebCore/platform/graphics/blackberry/Texture.h', u'Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.cpp', u'Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.h', u'Source/WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h', u'Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp', u'Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.h']" exit_code: 1 Source/WebCore/platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:56: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:289: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:290: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:291: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:292: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:293: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:295: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:296: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:297: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:301: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:303: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:306: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:307: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:309: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 14 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to comment #1) > Created an attachment (id=190722) [details] > Patch I think this is a bit much to review. Maybe it is better to split out the added files in a separate patch, which would make this one more manageable. Also crediting all persons involved is a good idea.

(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=190722) [details] [details] > > Patch > > I think this is a bit much to review. Maybe it is better to split out the added files in a separate patch, which would make this one more manageable. > Also crediting all persons involved is a good idea. I'll open a new bug for the new files. I haven't received a list of all the people yet, see PR 293208 for details.

(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #1) > > > Created an attachment (id=190722) [details] [details] [details] > > > Patch > > > > I think this is a bit much to review. Maybe it is better to split out the added files in a separate patch, which would make this one more manageable. > > Also crediting all persons involved is a good idea. > > I'll open a new bug for the new files. I haven't received a list of all the people yet, see PR 293208 for details. https://bugs.webkit.org/show_bug.cgi?id=111153

Created attachment 190965 [details] Patch

Comment on attachment 190965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190965&action=review Some nits but nothing that needs to be fixed in this patch. > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:33 > +#include <Vector.h> Not an improvement, since the former is preferred. Does not need to be part of this patch though. > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:304 > + char standardVertexShaderString[] = These could be const to move it into rodata. But not part of this patch... > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:595 > + glDisable(GL_BLEND); I see this structure recurring a lot, I wonder if we should make a helper function.

Comment on attachment 190965 [details] Patch Clearing flags on attachment: 190965 Committed r144465: <http://trac.webkit.org/changeset/144465>

All reviewed patches have been landed. Closing bug.