Bug 111056

Summary: [EFL][QT][WK2] Turn on ApplyPageScaleFactorInCompositor always.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cmarcelo, gyuyoung.kim, jturcotte, kenneth, luiz, mcatanzaro, mikhail.pozdnyakov, noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110298    
Bug Blocks:    
Attachments:
Description Flags
Patch andersca: review+

Dongseong Hwang
Reported 2013-02-28 01:52:02 PST
Currently, EFL and Qt turn on ApplyPageScaleFactorInCompositor when using fixed layout, but ApplyPageScaleFactorInCompositor is not related to fixed layout. When turning off ApplyPageScaleFactorInCompositor, the local transform of each layer is applied by page scale factor. It means that if turning off ApplyPageScaleFactorInCompositor we should not use page scale factor when making a transform matrix that CooridnatedGraphicsScene will use to draw. It is burden to each platform WebView, because a platform WebView differently deals with page scale factor case by case. So this patch turns on ApplyPageScaleFactorInCompositor always.
Attachments
Patch (11.94 KB, patch)
2013-03-03 16:50 PST, Dongseong Hwang 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-03-03 16:50:36 PST
Created attachment 191153 [details] Patch
Build Bot
Comment 2 2013-03-05 18:58:48 PST
Comment on attachment 191153 [details] Patch Attachment 191153 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/16992350
Gyuyoung Kim
Comment 3 2013-07-16 18:43:51 PDT
Comment on attachment 191153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191153&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:98 > + m_webPage->corePage()->settings()->setApplyPageScaleFactorInCompositor(true); Looks fine on my side. Noam, what do you think ?
Noam Rosenthal
Comment 4 2013-07-16 23:58:26 PDT
Comment on attachment 191153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191153&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:98 >> + m_webPage->corePage()->settings()->setApplyPageScaleFactorInCompositor(true); > > Looks fine on my side. Noam, what do you think ? Looks good to me, though this needs an owner review since it touches WebPage.cpp.
Gyuyoung Kim
Comment 5 2013-07-17 00:13:17 PDT
CC'ing Benjamin, could you take a look ?
Anders Carlsson
Comment 6 2013-10-02 21:22:27 PDT
Comment on attachment 191153 [details] Patch This patch looks good to me, but don't land the Qt test result since Qt has been removed.
Michael Catanzaro
Comment 7 2017-03-11 10:36:26 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.