Bug 110663

Summary: SelectorChecker should not know about SelectorCheckerFastPath.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, eric, esprehn+autocc, koivisto, macpherson, menard, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2013-02-22 16:52:28 PST
SelectorChecker should not know about SelectorCheckerFastPath.
Attachments
Patch (6.98 KB, patch)
2013-02-22 17:01 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.48 KB, patch)
2013-02-23 10:14 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.45 KB, patch)
2013-02-23 20:54 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2013-02-22 17:01:16 PST
Created attachment 189868 [details] Patch
Antti Koivisto
Comment 2 2013-02-23 04:00:39 PST
Comment on attachment 189868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189868&action=review > Source/WebCore/css/SelectorChecker.cpp:77 > -bool SelectorChecker::matches(const CSSSelector* selector, Element* element, bool isFastCheckableSelector) const > +bool SelectorChecker::matches(const CSSSelector* selector, Element* element) const > { > - if (isFastCheckableSelector && !element->isSVGElement()) { > - SelectorCheckerFastPath selectorCheckerFastPath(selector, element); > - if (!selectorCheckerFastPath.matchesRightmostSelector(VisitedMatchDisabled)) > - return false; > - return selectorCheckerFastPath.matches(); > - } > - > PseudoId ignoreDynamicPseudo = NOPSEUDO; > return match(SelectorCheckingContext(selector, element, SelectorChecker::VisitedMatchDisabled), ignoreDynamicPseudo, DOMSiblingTraversalStrategy()) == SelectorMatches; > } Maybe you should just remove this whole function? It does not serve much purpose anymore.
Dimitri Glazkov (Google)
Comment 3 2013-02-23 08:40:31 PST
(In reply to comment #2) > Maybe you should just remove this whole function? It does not serve much purpose anymore. Will do!
Dimitri Glazkov (Google)
Comment 4 2013-02-23 10:14:46 PST
Created attachment 189931 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-02-23 12:54:31 PST
Comment on attachment 189931 [details] Patch for landing Rejecting attachment 189931 [details] from commit-queue. New failing tests: fast/regions/region-style-color.html Full output: http://queues.webkit.org/results/16718889
Dimitri Glazkov (Google)
Comment 6 2013-02-23 20:54:59 PST
Created attachment 189955 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-02-23 22:20:29 PST
Comment on attachment 189955 [details] Patch for landing Clearing flags on attachment: 189955 Committed r143858: <http://trac.webkit.org/changeset/143858>
WebKit Review Bot
Comment 8 2013-02-23 22:20:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.