Bug 110418

Summary: [CSS Grid Layout] Implement grid growth during auto placement
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103316    
Attachments:
Description Flags
Proposed change: Added missing piece, even reusing GridIterator::nextEmptyGridArea (OK, I lied on whether we would use it, thanks for catching that Tony). none

Julien Chaffraix
Reported 2013-02-20 17:38:18 PST
Bug 110277 landed the bulk of the algorithm but didn't include the potential growth during placement to limit the size of the change. Once the growth is implemented, our implementation should handle properly all cases.
Attachments
Proposed change: Added missing piece, even reusing GridIterator::nextEmptyGridArea (OK, I lied on whether we would use it, thanks for catching that Tony). (9.41 KB, patch)
2013-02-20 17:57 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-02-20 17:57:46 PST
Created attachment 189430 [details] Proposed change: Added missing piece, even reusing GridIterator::nextEmptyGridArea (OK, I lied on whether we would use it, thanks for catching that Tony).
WebKit Review Bot
Comment 2 2013-02-21 09:55:28 PST
Comment on attachment 189430 [details] Proposed change: Added missing piece, even reusing GridIterator::nextEmptyGridArea (OK, I lied on whether we would use it, thanks for catching that Tony). Clearing flags on attachment: 189430 Committed r143621: <http://trac.webkit.org/changeset/143621>
WebKit Review Bot
Comment 3 2013-02-21 09:55:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.