Bug 110249
Summary: | Style checker incorrectly flagging a patch for mimetype errors | ||
---|---|---|---|
Product: | WebKit | Reporter: | Philip Rogers <pdr> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | abarth, alancutter, cbiesinger |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Philip Rogers
The style checker is complaining about a patch on the following bug ("Rebased patch (3)"): https://bugs.webkit.org/show_bug.cgi?id=99984. The queue results (http://queues.webkit.org/results/16615901) say:
Failed to run "['/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-feeder-01', 'check-style-local', '--non-interactive', '--quiet']" exit_code: 2 cwd: /mnt/git/webkit-style-queue
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/chromium/TestExpectations', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.png', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.txt', u'LayoutTests/svg/as-image/image-preserveAspectRatio-all.svg', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all-expected.png', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all-expected.txt', u'LayoutTests/svg/filters/feImage-preserveAspectRatio-all.svg', u'Source/WebCore/ChangeLog', u'Source/WebCore/svg/SVGPreserveAspectRatio.cpp']" exit_code: 1
LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 13 files
This patch passes the style checker locally and I verified the property is set in svn, and in the patchfile itself.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Christian Biesinger
*** This bug has been marked as a duplicate of bug 107724 ***