Bug 110097

Summary: [WK2] Port RemoteNetworkingContext for Soup
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, buildbot, cgarcia, commit-queue, darin, gustavo, gyuyoung.kim, jesus, kenneth, laszlo.gombos, ossy, rniwa, skyul, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108832, 118231    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Balazs Kelemen
Reported 2013-02-18 01:58:13 PST
Make this interface portable and add an implementation for the Soup network backend which is used by several ports.
Attachments
Patch (16.41 KB, patch)
2013-02-18 06:21 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (18.40 KB, patch)
2013-06-30 19:46 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (18.38 KB, patch)
2013-07-01 03:45 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (17.29 KB, patch)
2013-08-26 06:59 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (17.36 KB, patch)
2013-09-26 07:59 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (17.71 KB, patch)
2013-09-27 03:56 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (17.72 KB, patch)
2013-09-27 04:31 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-02-18 04:06:33 PST
Being one of the active maintainers of the WK soup backend I'm interested in helping with this effort.
Balazs Kelemen
Comment 2 2013-02-18 06:12:42 PST
(In reply to comment #1) > Being one of the active maintainers of the WK soup backend I'm interested in helping with this effort. Thanks. For now it will mostly be stubs and a bit of refactoring. Later we can implement private browsing sessions which probably requires more soup knowledge.
Balazs Kelemen
Comment 3 2013-02-18 06:21:27 PST
Created attachment 188871 [details] Patch
Kwang Yul Seo
Comment 4 2013-06-30 19:46:22 PDT
Created attachment 205782 [details] Patch
Kwang Yul Seo
Comment 5 2013-06-30 19:50:13 PDT
(In reply to comment #4) Build fix as RemoteNetworkingContext::privateBrowsingSession is changed to return a pointer in r150537.
Build Bot
Comment 6 2013-06-30 20:10:58 PDT
Comment on attachment 205782 [details] Patch Attachment 205782 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1001366
Build Bot
Comment 7 2013-06-30 20:25:00 PDT
Comment on attachment 205782 [details] Patch Attachment 205782 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/943930
Kwang Yul Seo
Comment 8 2013-07-01 03:45:53 PDT
Created attachment 205795 [details] Patch
Kwang Yul Seo
Comment 9 2013-07-01 03:47:07 PDT
(In reply to comment #8) > Created an attachment (id=205795) [details] > Patch Mac build fix. RemoteNetworkingContext::storageSession() was mistakenly declared twice.
Brady Eidson
Comment 10 2013-07-04 18:27:05 PDT
Comment on attachment 205795 [details] Patch Seems fine. I'll let a Soup guy review, then will sign off.
Sergio Villar Senin
Comment 11 2013-07-05 01:29:44 PDT
(In reply to comment #10) > (From update of attachment 205795 [details]) > Seems fine. I'll let a Soup guy review, then will sign off. As this is mostly a refactoring and knowing that there is actually no specific soup code yet, I think you can safely sign off.
Kwang Yul Seo
Comment 12 2013-07-08 18:27:53 PDT
CC'ing Gustavo Noronha Silva
Kwang Yul Seo
Comment 13 2013-07-25 02:17:23 PDT
gns, would you review the patch please?
Csaba Osztrogonác
Comment 14 2013-08-26 06:59:35 PDT
Created attachment 209650 [details] Patch Updated to ToT: solved conflicts in project.pbxproj, removed the change in the non-existent SyncNetworkResourceLoader.cpp
Csaba Osztrogonác
Comment 15 2013-09-26 07:57:53 PDT
Comment on attachment 209650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209650&action=review > Source/WebKit2/ChangeLog:23 > + * NetworkProcess/SyncNetworkResourceLoader.cpp: > + (WebKit::SyncNetworkResourceLoader::start): It should be removed.
Csaba Osztrogonác
Comment 16 2013-09-26 07:59:44 PDT
Created attachment 212710 [details] Patch
Csaba Osztrogonác
Comment 17 2013-09-26 08:01:00 PDT
Could you review this patch please?
Darin Adler
Comment 18 2013-09-26 09:28:56 PDT
Comment on attachment 212710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212710&action=review > Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:34 > +class RemoteNetworkingContext : public WebCore::NetworkingContext { As long as you are touching this, should mark this class FINAL. > Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:54 > + RemoteNetworkingContext(bool privateBrowsingEnabled, bool shouldClearReferrerOnHTTPSToHTTPRedirect) > + : m_privateBrowsingEnabled(privateBrowsingEnabled) > + , m_shouldClearReferrerOnHTTPSToHTTPRedirect(shouldClearReferrerOnHTTPSToHTTPRedirect) > + { } This will leave m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled uninitialized on PLATFORM(MAC), which is not what we want.
Csaba Osztrogonác
Comment 19 2013-09-27 03:56:00 PDT
Created attachment 212794 [details] Patch Thanks for the review, I added the FINAL and fixed the initialization.
Build Bot
Comment 20 2013-09-27 04:22:05 PDT
Comment on attachment 212794 [details] Patch Attachment 212794 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2659113
Csaba Osztrogonác
Comment 21 2013-09-27 04:31:40 PDT
Created attachment 212796 [details] Patch typo fixed
Csaba Osztrogonác
Comment 22 2013-10-07 09:12:14 PDT
(In reply to comment #19) > Created an attachment (id=212794) [details] > Patch > > Thanks for the review, I added the FINAL and fixed the initialization. Darin, could you review the updated patch please?
Csaba Osztrogonác
Comment 23 2013-10-10 06:06:21 PDT
Could you review the fixed patch, please?
WebKit Commit Bot
Comment 24 2013-10-10 14:33:14 PDT
Comment on attachment 212796 [details] Patch Clearing flags on attachment: 212796 Committed r157251: <http://trac.webkit.org/changeset/157251>
WebKit Commit Bot
Comment 25 2013-10-10 14:33:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.