Bug 110038

Summary: Stop passing around SelectorChecker in SelectorQuery, now that SelectorChecker is stack-allocated.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, eric, koivisto, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2013-02-16 16:17:05 PST
Stop passing around SelectorChecker, now that it's stack-allocated.
Attachments
Patch (6.57 KB, patch)
2013-02-16 16:19 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.48 KB, patch)
2013-02-16 16:50 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2013-02-16 16:19:59 PST
Created attachment 188738 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2013-02-16 16:48:32 PST
Comment on attachment 188738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188738&action=review > Source/WebCore/dom/SelectorQuery.cpp:67 > + SelectorChecker selectorChecker(rootNode->document(), SelectorChecker::QueryingRules); Eerk. This is not needed either. Will fix.
Dimitri Glazkov (Google)
Comment 3 2013-02-16 16:50:13 PST
Created attachment 188743 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-02-17 22:45:53 PST
Comment on attachment 188743 [details] Patch for landing Clearing flags on attachment: 188743 Committed r143152: <http://trac.webkit.org/changeset/143152>
WebKit Review Bot
Comment 5 2013-02-17 22:45:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.