Bug 109534

Summary: Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, ddkilzer, enrica, gyuyoung.kim, japhet, mifenton, mrobinson, ojan.autocc, rakuco, rniwa, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109517, 109557    
Bug Blocks: 109549    
Attachments:
Description Flags
Disables the feature on non-Mac ports andersca: review+, buildbot: commit-queue-

Ryosuke Niwa
Reported 2013-02-11 18:38:05 PST
Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
Attachments
Disables the feature on non-Mac ports (28.13 KB, patch)
2013-02-11 18:38 PST, Ryosuke Niwa 		andersca: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-02-11 18:38:42 PST
Created attachment 187748 [details] Disables the feature on non-Mac ports
Martin Robinson
Comment 2 2013-02-11 19:20:25 PST
The GTK+ bits look good!
Build Bot
Comment 3 2013-02-11 20:13:13 PST
Comment on attachment 187748 [details] Disables the feature on non-Mac ports Attachment 187748 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16492584
Anders Carlsson
Comment 4 2013-02-11 20:33:27 PST
Comment on attachment 187748 [details] Disables the feature on non-Mac ports View in context: https://bugs.webkit.org/attachment.cgi?id=187748&action=review > Source/WebCore/editing/DeleteButtonController.cpp:285 > + EditorClient* clinet = m_frame->editor()->client(); clinet -> client.
Ryosuke Niwa
Comment 5 2013-02-11 20:57:04 PST
Committed r142576: <http://trac.webkit.org/changeset/142576>
David Kilzer (:ddkilzer)
Comment 6 2013-02-12 08:47:20 PST
(In reply to comment #5) > Committed r142576: <http://trac.webkit.org/changeset/142576> Follow-up build fix: Committed r142629: < http://trac.webkit.org/changeset/142629>
Note You need to log in before you can comment on or make changes to this bug.