Bug 108751

Hi, Thanks for the report. It has been fixed by http://trac.webkit.org/changeset/140560 and it is covered by a regression test : http://trac.webkit.org/changeset/140560/trunk/LayoutTests/transitions/transitions-parsing.html Thanks for the report. *** This bug has been marked as a duplicate of bug 105428 ***

Oh, sorry. I may not have made myself clear enough. I report a bug of transition 'shorthand' property, not transition-property property. Please confirm this code, and comment #0's spec. >(function (body) { > body.style.transition = 'none, none'; > body.insertAdjacentHTML('AfterBegin', body.style.transition === ''); >}(document.body)); http://jsfiddle.net/syoichi/qTcCR/

I will investigate.

Created attachment 188577 [details] Patch

Comment on attachment 188577 [details] Patch Attachment 188577 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16589163 New failing tests: fast/css/transform-inline-style.html fast/css/transform-inline-style-remove.html

Created attachment 188585 [details] Patch

Comment on attachment 188585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188585&action=review r+ but I think we need to clarify the names before landing. > Source/WebCore/ChangeLog:23 > + (WebCore::AnimationParseContext::hasFirstAnimationCommitted): I suggest "hasCommittedFirstAnimation" (getter) > Source/WebCore/ChangeLog:28 > + (WebCore::AnimationParseContext::markParsingAnimationPropertyFinished): > + In the shorthand as soon as a keyword has been found then the parsing > + is 'finished', if any other animation/transition declaration part of > + the shorthand are with a keyword then it's invalid. > + (WebCore::AnimationParseContext::canParseMoreAnimationProperty): This one is a tricky name, because it is so similar to the one below, but is only used within shorthands :( How about "canParseAnotherAnimationPropertyKeywordInShorthand" (getter) and "animationPropertyKeywordParsedInShorthand" (setter). Although I don't like that this has flipped the logic from your existing code, and also that the getter returns the opposite of the setter (if that makes sense). > Source/WebCore/ChangeLog:30 > + (WebCore::AnimationParseContext::hasAnimationPropertyKeyword): > + (WebCore::AnimationParseContext::commitAnimationPropertyKeyword): How about "hasSeenAnimationPropertyKeyword" (getter) and "sawAnimationPropertyKeyword" (setter)?

Comment on attachment 188585 [details] Patch Even my suggestions are going against the style guide somewhat. Also, why not just use a struct for the context, without any methods?

Created attachment 188601 [details] Patch for landing

Comment on attachment 188601 [details] Patch for landing Rejecting attachment 188601 [details] from commit-queue. alexis@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Committed r143019: <http://trac.webkit.org/changeset/143019>

I confirmed that this bug is fixed on Chromium 27.0.1414.0 (182962). Thanks!