Bug 108705

Summary: Update LayoutTests scripts to skip webgl folder on ports
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gregg Tavares
Reported 2013-02-01 15:11:25 PST
Update LayoutTests scripts to skip webgl folder on ports
Attachments
Patch (3.51 KB, patch)
2013-02-01 15:12 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2013-02-01 15:24 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2013-02-01 15:31 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2013-02-01 15:12:51 PST
Created attachment 186156 [details] Patch
Gregg Tavares
Comment 2 2013-02-01 15:14:41 PST
Before I check in the WebGL Conformance Tests I think I need this change so that ports that do not support WebGL skip the tests
WebKit Review Bot
Comment 3 2013-02-01 15:16:03 PST
Attachment 186156 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/layout_tests/port/base.py', u'Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py']" exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Pranke
Comment 4 2013-02-01 15:20:22 PST
Comment on attachment 186156 [details] Patch looks fine. fix the style errors :)
Gregg Tavares
Comment 5 2013-02-01 15:24:39 PST
Created attachment 186161 [details] Patch
Gregg Tavares
Comment 6 2013-02-01 15:31:39 PST
Created attachment 186164 [details] Patch
WebKit Review Bot
Comment 7 2013-02-01 18:18:27 PST
Comment on attachment 186164 [details] Patch Clearing flags on attachment: 186164 Committed r141672: <http://trac.webkit.org/changeset/141672>
WebKit Review Bot
Comment 8 2013-02-01 18:18:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.