Bug 108609
| Summary: | [Qt] New inspector-protocol/page/javascriptDialogEvents.html fails on Qt. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ádám Kallai <kadam> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | kkania, ossy, pfeldman, zarvai |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 87008 | ||
Ádám Kallai
This test started to fail r141555.
Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r141567%20(47621)/inspector-protocol/page/javascriptDialogEvents-pretty-diff.html
Could you check it please? Is it a correct result?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ken Kania
The test passed on the qt ews bots. Any ideas what might be different about this bot? I'm building locally now to see what might be wrong. I'll keep you posted.
Ken Kania
The result you see is correct behavior.
Not sure why the ews bot passed, but the QT DRT just prints "CONFIRM:" instead of "CONFIRM NAVIGATION:" for the before unload prompt. This is because ChromeClientQt::runBeforeUnloadConfirmPanel simply delegates to runJavaScriptConfirm, which prints CONFIRM: instead of CONFIRM NAVIGATION:, unlike the other DRTs.
The one other test that depends on the unload confirm panel is disabled on qt too: fast/loader/form-submission-after-beforeunload-cancel.html
See https://bugs.webkit.org/show_bug.cgi?id=66162.
Ádám Kallai
Yes, there is a difference. The qt ews only build patch. Therefore it could be green in this case. I will add to platform specific expected for this test.
Thank for your response.
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.