Bug 108458

Summary: [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Tommy Widenflycht
Reported 2013-01-31 04:19:23 PST
[chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
Attachments
Patch (70.20 KB, patch)
2013-01-31 04:21 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2013-01-31 04:21:19 PST
Created attachment 185744 [details] Patch
WebKit Review Bot
Comment 2 2013-01-31 04:24:06 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tommy Widenflycht
Comment 3 2013-01-31 04:25:18 PST
Only renames in the patch. I have a corresponding Chromium patch lined up which does the rename there which will be committed as soon as this change is rolled in. The main reason is that the old names confused other developers who have no idea what a "Descriptor" or "Component" is; and concludes the cleanup of the WebKit names.
Adam Barth
Comment 4 2013-01-31 10:50:06 PST
Comment on attachment 185744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185744&action=review > Source/Platform/chromium/public/WebMediaStreamComponent.h:36 > +// The name WebMediaStreamComponent is EXTREMELY DEPRECATED. EXTREMELY DEPRECATED!!!
WebKit Review Bot
Comment 5 2013-01-31 11:03:05 PST
Comment on attachment 185744 [details] Patch Clearing flags on attachment: 185744 Committed r141444: <http://trac.webkit.org/changeset/141444>
WebKit Review Bot
Comment 6 2013-01-31 11:03:10 PST
All reviewed patches have been landed. Closing bug.
Tommy Widenflycht
Comment 7 2013-02-01 01:26:20 PST
(In reply to comment #4) > (From update of attachment 185744 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185744&action=review > > > Source/Platform/chromium/public/WebMediaStreamComponent.h:36 > > +// The name WebMediaStreamComponent is EXTREMELY DEPRECATED. > > EXTREMELY DEPRECATED!!! Yes, if someone uses it for new stuff I'll hit them with a rubber chicken ;) Hopefully the Chromium rename patch goes asap so that I can remove these two compatibility headers later today.
Note You need to log in before you can comment on or make changes to this bug.