Bug 107956

Summary: Adding a text track should not make controls visible
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, feature-media-reviews, ojan.autocc, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed patch
dino: review+
Updated patch.
webkit.review.bot: commit-queue-
Updated patch. none

Eric Carlson
Reported 2013-01-25 09:34:19 PST
Adding a text track makes controls visible
Attachments
Proposed patch (9.25 KB, patch)
2013-01-25 09:49 PST, Eric Carlson 		dino: review+
DetailsFormatted DiffDiff
Updated patch. (9.38 KB, patch)
2013-01-25 12:13 PST, Eric Carlson 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Updated patch. (9.48 KB, patch)
2013-01-25 13:19 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-01-25 09:49:17 PST
Created attachment 184767 [details] Proposed patch
Eric Carlson
Comment 2 2013-01-25 12:13:30 PST
Created attachment 184791 [details] Updated patch. Updated patch as the first version sometimes creates hidden controls when we did not previously. This isn't really a change in functionality, but it causes some tests that dump the render tree to fail so attempt to restore the previous behavior. Not marking r? so the bots can chew on it first.
WebKit Review Bot
Comment 3 2013-01-25 12:58:46 PST
Comment on attachment 184791 [details] Updated patch. Attachment 184791 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16122473 New failing tests: media/media-captions-no-controls.html
Eric Carlson
Comment 4 2013-01-25 13:19:03 PST
Created attachment 184801 [details] Updated patch. Oops, the results for my new test depended on the side effect I removed in the second patch :-O
Eric Carlson
Comment 5 2013-01-25 13:43:15 PST
Comment on attachment 184801 [details] Updated patch. Committed r140862.
Radar WebKit Bug Importer
Comment 6 2013-01-27 12:12:36 PST
<rdar://problem/13093844>
Note You need to log in before you can comment on or make changes to this bug.