Bug 107816

Summary: Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 97978    
Attachments:
Description Flags
Patch
none
Patch none

Mike West
Reported 2013-01-24 06:05:06 PST
Currently `console.debug` is an alias to `console.log`. Since we now have amazing rendering of debug-level messages, we should change the severity to match. Open question: should we map `console.info` to TipMessageLevel? Should we get rid of Tip entirely, since I'm not at all sure what it means? :)
Attachments
Patch (3.26 KB, patch)
2013-01-24 06:16 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (4.77 KB, patch)
2013-01-24 08:06 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-01-24 06:16:45 PST
Created attachment 184479 [details] Patch
WebKit Review Bot
Comment 2 2013-01-24 06:52:14 PST
Comment on attachment 184479 [details] Patch Rejecting attachment 184479 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184479, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: webkit-commit-queue Parsed 4 diffs from patch file(s). patch: **** Can't create file /tmp/pp1fq8Qo : No space left on device patch: **** Can't create file /tmp/ppLpyiAo : No space left on device patch: **** Can't create file /tmp/ppFkbZlp : No space left on device patch: **** Can't create file /tmp/pp4mAEYo : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16077739
Mike West
Comment 3 2013-01-24 06:53:20 PST
(In reply to comment #2) > (From update of attachment 184479 [details]) > Rejecting attachment 184479 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184479, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue > > Last 500 characters of output: > webkit-commit-queue > > Parsed 4 diffs from patch file(s). > patch: **** Can't create file /tmp/pp1fq8Qo : No space left on device > patch: **** Can't create file /tmp/ppLpyiAo : No space left on device > patch: **** Can't create file /tmp/ppFkbZlp : No space left on device > patch: **** Can't create file /tmp/pp4mAEYo : No space left on device > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue > > Full output: http://queues.webkit.org/results/16077739 Oh noes! My one-line patch is too big! *cough* I'll try this again when the CQ is less broken. :)
Build Bot
Comment 4 2013-01-24 07:31:18 PST
Comment on attachment 184479 [details] Patch Attachment 184479 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16097200 New failing tests: inspector/extensions/extensions-console.html
Mike West
Comment 5 2013-01-24 08:06:00 PST
Created attachment 184500 [details] Patch
WebKit Review Bot
Comment 6 2013-01-24 12:41:51 PST
Comment on attachment 184500 [details] Patch Clearing flags on attachment: 184500 Committed r140709: <http://trac.webkit.org/changeset/140709>
WebKit Review Bot
Comment 7 2013-01-24 12:41:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.