Bug 107742

Summary:

Message receiver generation should work in terms of MessageReceiver objects

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, benjamin, eric.carlson, feature-media-reviews, gyuyoung.kim, hausmann, kadam, morrita, ossy, seokju, webkit.review.bot, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

107787

Bug Blocks:

107760

Attachments:

Description	Flags
Patch	bdakin: review+

Anders Carlsson

Reported 2013-01-23 14:50:58 PST

Message receiver generation should work in terms of MessageReceiver objects

Attachments
Patch (49.85 KB, patch) 2013-01-23 14:54 PST, Anders Carlsson	bdakin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-01-23 14:54:14 PST

Created attachment 184318 [details] Patch

Anders Carlsson

Comment 2 2013-01-23 15:09:42 PST

Committed r140605: <http://trac.webkit.org/changeset/140605>

Csaba Osztrogonác

Comment 3 2013-01-23 15:41:31 PST

It broke the Qt WK2 build: generated/CoordinatedLayerTreeHostProxyMessageReceiver.cpp:57:129: error: no 'void WebKit::CoordinatedLayerTreeHostProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&)' member function declared in class 'WebKit::CoordinatedLayerTreeHostProxy' generated/CoordinatedLayerTreeHostMessageReceiver.cpp:40:124: error: no 'void WebKit::CoordinatedLayerTreeHost::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&)' member function declared in class 'WebKit::CoordinatedLayerTreeHost' cc Qt guys to fix it.

Hajime Morrita

Comment 4 2013-01-23 17:25:08 PST

Same for my local mac-wk2. Needs clobber build? CompileC WebKeyValueStorageManagerMessageReceiver.o /Users/morrita/work/webkit/alice/WebKitBuild/Debug/DerivedSources/WebKit2/WebKeyValueStorageManagerMessageReceiver.cpp:36:33: error: out-of-line definition of 'didReceiveWebKeyValueStorageManagerMessage' does not match any declaration in 'WebKit::WebKeyValueStorageManager' void WebKeyValueStorageManager::didReceiveWebKeyValueStorageManagerMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder& decoder) 1 error generated.

Gyuyoung Kim

Comment 5 2013-01-23 22:44:15 PST

I file Bug 107788 to fix build break on other ports. Could you take a look it ?

Seokju Kwon

Comment 6 2013-01-23 23:27:15 PST

Fix build break on efl with r140656 (Bug 107787)

Note You need to log in before you can comment on or make changes to this bug.