Bug 107569

Summary: BackgroundHTMLParser should simulate tree building in a separate function
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
tonyg: review+
Patch eric: review+

Adam Barth
Reported 2013-01-22 10:51:12 PST
BackgroundHTMLParser should simulate tree building in a separate function
Attachments
Patch (6.27 KB, patch)
2013-01-22 10:52 PST, Adam Barth 		tonyg: review+
DetailsFormatted DiffDiff
Patch (6.21 KB, patch)
2013-01-22 10:53 PST, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-01-22 10:52:09 PST
Created attachment 184017 [details] Patch
Adam Barth
Comment 2 2013-01-22 10:53:36 PST
Created attachment 184019 [details] Patch
Tony Gentilcore
Comment 3 2013-01-22 10:59:34 PST
Comment on attachment 184017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184017&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:129 > + // FIXME: This is just a copy of Tokenizer::updateStateFor which doesn't use HTMLNames. This isn't exactly true any more. I'd change it to something like: // FIXME: This is just a copy of Tokenizer::updateStateFor which uses threadSafeMatches.
Eric Seidel (no email)
Comment 4 2013-01-22 10:59:45 PST
Comment on attachment 184019 [details] Patch LGTM. We had talked about pulling it out into a separate class even.
Adam Barth
Comment 5 2013-01-22 11:13:45 PST
Committed r140441: <http://trac.webkit.org/changeset/140441>
Note You need to log in before you can comment on or make changes to this bug.