Bug 107485

Summary:

[EFL][WebGL] Enable WebGL layout tests.

Product:

WebKit

Reporter:

Kalyan <kalyan.kondapally>

Component:

WebKit EFL

Assignee:

Kalyan <kalyan.kondapally>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, jussi.kukkonen, kenneth, laszlo.gombos, lucas.de.marchi, ostap73, rakuco, tmpsantos, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

104459, 104506

Attachments:

Description	Flags
WIP	none
patch	none
patchv2	none
patchv3	none
patchv4	none

Kalyan

Reported 2013-01-21 16:19:52 PST

Most of the fixes are in mainline now and layout tests seem quite stable and could be enabled. I will upload an updated testexpectation file.

Attachments
WIP (3.60 KB, text/plain) 2013-01-22 00:17 PST, Kalyan	no flags	Details
patch (3.60 KB, patch) 2013-01-22 00:51 PST, Kalyan	no flags	Details Formatted Diff Diff
patchv2 (5.52 KB, patch) 2013-01-22 01:28 PST, Kalyan	no flags	Details Formatted Diff Diff
patchv3 (5.52 KB, patch) 2013-01-22 01:44 PST, Kalyan	no flags	Details Formatted Diff Diff
patchv4 (5.55 KB, patch) 2013-01-22 07:59 PST, Kalyan	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Kalyan

Comment 1 2013-01-22 00:17:54 PST

Created attachment 183910 [details] WIP

Kalyan

Comment 2 2013-01-22 00:51:05 PST

Created attachment 183914 [details] patch not marking for review or cq yet

Kalyan

Comment 3 2013-01-22 01:28:45 PST

Created attachment 183925 [details] patchv2

Kalyan

Comment 4 2013-01-22 01:44:26 PST

Created attachment 183929 [details] patchv3 removed unnecessary new line.

Jussi Kukkonen (jku)

Comment 5 2013-01-22 05:30:44 PST

Comment on attachment 183929 [details] patchv3 View in context: https://bugs.webkit.org/attachment.cgi?id=183929&action=review I've run the tests quite extensively and these results are good for me too, with the one exception I mentioned. I didn't check if every flaky one is still flaky but Flakiness deshboard will let us now later anyway. > LayoutTests/platform/efl/TestExpectations:334 > # Note webkit.org/b/104506, random crashes comment is now obsolete > LayoutTests/platform/efl/TestExpectations:338 > # Note webkit.org/b/104506, random crashes this too > LayoutTests/platform/efl/TestExpectations:342 > # Note webkit.org/b/104506, random crashes and this > LayoutTests/platform/efl/TestExpectations:1730 > +webkit.org/b/106547 fast/canvas/webgl/type-conversion-test.html [ Crash ] This one actually passes consistently for me.

Kalyan

Comment 6 2013-01-22 07:59:49 PST

Created attachment 183991 [details] patchv4

Viatcheslav Ostapenko

Comment 7 2013-01-22 09:36:53 PST

(In reply to comment #5) > (From update of attachment 183929 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183929&action=review > > > LayoutTests/platform/efl/TestExpectations:1730 > > +webkit.org/b/106547 fast/canvas/webgl/type-conversion-test.html [ Crash ] > > This one actually passes consistently for me. There are several different drivers in mesa and it seems it depends on your HW. For me on Ubuntu 12.04 32bit with mesa sw/llvm rendering it crashes every time.

Laszlo Gombos

Comment 8 2013-01-22 17:12:24 PST

Comment on attachment 183991 [details] patchv4 r=me.

WebKit Review Bot

Comment 9 2013-01-22 17:44:46 PST

Comment on attachment 183991 [details] patchv4 Clearing flags on attachment: 183991 Committed r140492: <http://trac.webkit.org/changeset/140492>

WebKit Review Bot

Comment 10 2013-01-22 17:44:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.