Bug 107453

Summary: PostMessageTimer in DOMWindow.cpp should be suspendable
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
Safer delete none

Yong Li
Reported 2013-01-21 08:02:51 PST
I just noticed that PostMessageTimer defined in DOMWindow.cpp is not ActiveDOMObject, so it can fire (and execute JS) while all ActiveDOMObjects are supposed to be suspended.
Attachments
the patch (2.98 KB, patch)
2013-01-21 08:21 PST, Yong Li 		no flags
DetailsFormatted DiffDiff
Safer delete (3.53 KB, patch)
2013-01-21 10:47 PST, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2013-01-21 08:21:58 PST
Created attachment 183791 [details] the patch
Yong Li
Comment 2 2013-01-21 10:28:17 PST
Comment on attachment 183791 [details] the patch the delete might be dangerous... it could end up with double delete if the context is destroyed while event is being dispatched. will update the patch
Yong Li
Comment 3 2013-01-21 10:47:28 PST
Created attachment 183805 [details] Safer delete
Andreas Kling
Comment 4 2014-02-05 11:10:21 PST
Comment on attachment 183805 [details] Safer delete Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.