Bug 107073

Summary: [TexMap] Remove GraphicsLayer in TextureMapperLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, noam, rakuco, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 105787, 107090, 107099, 107629    
Bug Blocks: 103854, 108312, 107912    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
=rebase upstream
noam: review+, noam: commit-queue-
Patch for landing
none
Patch
none
Patch
none
Patch none

Dongseong Hwang
Reported 2013-01-16 17:47:49 PST
Remove the dependency of TextureMapperLayer on GraphicsLayer. It is needed to remove GraphicsLayerTextureMapper in LayerTreeRenderer.
Attachments
Patch (44.01 KB, patch)
2013-01-16 18:03 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (44.26 KB, patch)
2013-01-16 20:28 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (44.29 KB, patch)
2013-01-16 22:50 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (43.46 KB, patch)
2013-01-17 20:40 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (43.71 KB, patch)
2013-01-17 22:33 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
=rebase upstream (43.63 KB, patch)
2013-01-18 20:11 PST, Dongseong Hwang 		noam: review+
noam: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (43.42 KB, patch)
2013-01-24 21:56 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (43.03 KB, patch)
2013-01-25 02:10 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (60.92 KB, patch)
2013-01-30 00:03 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (43.25 KB, patch)
2013-01-30 01:04 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-01-16 18:03:19 PST
Created attachment 183079 [details] Patch
Dongseong Hwang
Comment 2 2013-01-16 18:05:16 PST
This patch depends on Bug 105787. Could you review Bug 105787 firstly?
Dongseong Hwang
Comment 3 2013-01-16 20:28:04 PST
Created attachment 183105 [details] Patch
Dongseong Hwang
Comment 4 2013-01-16 22:50:40 PST
Created attachment 183125 [details] Patch
Dongseong Hwang
Comment 5 2013-01-16 22:53:17 PST
This patch needs to land Bug 107090. Without Bug 107090, TexMap draws with wrong anchorPoint, after this patch.
Dongseong Hwang
Comment 6 2013-01-17 20:40:20 PST
Created attachment 183359 [details] Patch
Dongseong Hwang
Comment 7 2013-01-17 22:33:36 PST
Created attachment 183379 [details] Patch
Noam Rosenthal
Comment 8 2013-01-18 10:32:37 PST
Is this up for review?
Dongseong Hwang
Comment 9 2013-01-18 18:25:44 PST
(In reply to comment #8) > Is this up for review? Yes!
Dongseong Hwang
Comment 10 2013-01-18 20:11:25 PST
Created attachment 183595 [details] =rebase upstream
Noam Rosenthal
Comment 11 2013-01-22 04:15:18 PST
Comment on attachment 183595 [details] =rebase upstream View in context: https://bugs.webkit.org/attachment.cgi?id=183595&action=review > Source/WebCore/ChangeLog:14 > + Covered by existing variables tests. Remove the word "variables" > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:102 > + notifyChange(ContentsDisplayChange); This seems like it should be in a different patch.
Dongseong Hwang
Comment 12 2013-01-22 18:14:09 PST
(In reply to comment #11) > (From update of attachment 183595 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183595&action=review Thank you for review! > > Source/WebCore/ChangeLog:14 > > + Covered by existing variables tests. > > Remove the word "variables" OK. Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:102 > > + notifyChange(ContentsDisplayChange); > > This seems like it should be in a different patch. I'll make it in a different patch. After landing Bug 105787, I'll commit. Could you review Bug 107099 that blocks this bug?
Dongseong Hwang
Comment 13 2013-01-24 21:56:57 PST
Created attachment 184660 [details] Patch for landing
Dongseong Hwang
Comment 14 2013-01-25 02:10:59 PST
Created attachment 184706 [details] Patch
Dongseong Hwang
Comment 15 2013-01-30 00:03:10 PST
Created attachment 185409 [details] Patch
Dongseong Hwang
Comment 16 2013-01-30 01:04:52 PST
Created attachment 185424 [details] Patch
Dongseong Hwang
Comment 17 2013-01-30 01:08:46 PST
The previous patch has lots of somethinkg like backing store because of my mistake. The backing store stub is already landed in Bug 107099. This patch does not have backing store code, and focuses on removing GraphicsLayer in TextureMapperLayer.
WebKit Review Bot
Comment 18 2013-01-30 02:22:19 PST
Comment on attachment 185424 [details] Patch Clearing flags on attachment: 185424 Committed r141238: <http://trac.webkit.org/changeset/141238>
WebKit Review Bot
Comment 19 2013-01-30 02:22:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.