Bug 106165

Summary:

REGRESSION(r138834): http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html is flaky

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Page Loading

Assignee:

Mike West <mkwst>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, gyuyoung.kim, mkwst, mkwst+watchlist, rakuco, tdanderson, webkit.review.bot

Priority:

Keywords:

LayoutTestFailure, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

105374

Attachments:

Description	Flags
Patch	none

Ryosuke Niwa

Reported 2013-01-04 19:51:38 PST

The test added by http://trac.webkit.org/changeset/138834 has been flaky on all bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Freport-uri-from-javascript.html

Attachments
Patch (7.50 KB, patch) 2013-01-05 00:04 PST, Mike West	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-01-04 19:56:52 PST

Added a flaky test expectation in http://trac.webkit.org/changeset/138885.

Ryosuke Niwa

Comment 2 2013-01-04 19:58:32 PST

*** Bug 106153 has been marked as a duplicate of this bug. ***

Ryosuke Niwa

Comment 3 2013-01-04 20:00:02 PST

One more update: http://trac.webkit.org/changeset/138886

Mike West

Comment 4 2013-01-04 23:09:46 PST

Hrm. The line numbers are incorrect fairly often. That's no good. I'll leave the test running for a bit locally to see if I can track down the error. Thanks for raising this, and for skipping the test.

Mike West

Comment 5 2013-01-04 23:56:29 PST

Looks like I chose a poor injection mechanism; the existing file injects two script tags, which generates two violation reports, delivered in an indeterminate order. I'll create a more deterministic test, and upload it shortly for review.

Mike West

Comment 6 2013-01-05 00:04:49 PST

Created attachment 181430 [details] Patch

Mike West

Comment 7 2013-01-05 00:05:39 PST

The attached patch should make the bots happier. Let's see what EWS thinks.

WebKit Review Bot

Comment 8 2013-01-05 13:22:14 PST

Comment on attachment 181430 [details] Patch Clearing flags on attachment: 181430 Committed r138907: <http://trac.webkit.org/changeset/138907>

WebKit Review Bot

Comment 9 2013-01-05 13:22:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.