Bug 106083

Summary: Regression(r138728): Causes crashes on the build bots
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, gyuyoung.kim, kenneth, macpherson, menard, naginenis, noam, simon.fraser, tmpsantos, tonikitoo, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105442    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-01-04 04:05:34 PST
crash log for WebKitTestRunner (pid 452): STDOUT: <empty> STDERR: SHOULD NEVER BE REACHED STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/animation/TimingFunction.h(111) : static WTF::PassRefPtr<WebCore::CubicBezierTimingFunction> WebCore::CubicBezierTimingFunction::create(WebCore::CubicBezierTimingFunction::TimingFunctionPreset) STDERR: 1 0x7fa0674c9728 WebCore::CubicBezierTimingFunction::create(WebCore::CubicBezierTimingFunction::TimingFunctionPreset) STDERR: 2 0x7fa0642c5d1e CoreIPC::decodeTimingFunction(CoreIPC::ArgumentDecoder*, WTF::RefPtr<WebCore::TimingFunction>&) STDERR: 3 0x7fa0642c6659 CoreIPC::ArgumentCoder<WebCore::GraphicsLayerAnimation>::decode(CoreIPC::ArgumentDecoder*, WebCore::GraphicsLayerAnimation&) STDERR: 4 0x7fa0642cc879 bool CoreIPC::ArgumentDecoder::decode<WebCore::GraphicsLayerAnimation>(WebCore::GraphicsLayerAnimation&) STDERR: 5 0x7fa0642cbf02 CoreIPC::VectorArgumentCoder<false, WebCore::GraphicsLayerAnimation>::decode(CoreIPC::ArgumentDecoder*, WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul>&) STDERR: 6 0x7fa0642ca6a5 bool CoreIPC::ArgumentDecoder::decode<WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul> >(WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul>&) STDERR: 7 0x7fa0642c6950 CoreIPC::ArgumentCoder<WebCore::GraphicsLayerAnimations>::decode(CoreIPC::ArgumentDecoder*, WebCore::GraphicsLayerAnimations&) STDERR: 8 0x7fa06456cf0f bool CoreIPC::ArgumentDecoder::decode<WebCore::GraphicsLayerAnimations>(WebCore::GraphicsLayerAnimations&) STDERR: 9 0x7fa06456cde4 CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>::decode(CoreIPC::ArgumentDecoder*, CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 10 0x7fa06456cb69 CoreIPC::ArgumentCoder<CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations> >::decode(CoreIPC::ArgumentDecoder*, CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 11 0x7fa06456c7b7 bool CoreIPC::ArgumentDecoder::decode<CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations> >(CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 12 0x7fa06456bef0 void CoreIPC::handleMessage<Messages::CoordinatedLayerTreeHostProxy::SetLayerAnimations, WebKit::CoordinatedLayerTreeHostProxy, void (WebKit::CoordinatedLayerTreeHostProxy::*)(unsigned int, WebCore::GraphicsLayerAnimations const&)>(CoreIPC::MessageDecoder&, WebKit::CoordinatedLayerTreeHostProxy*, void (WebKit::CoordinatedLayerTreeHostProxy::*)(unsigned int, WebCore::GraphicsLayerAnimations const&)) STDERR: 13 0x7fa06456b334 WebKit::CoordinatedLayerTreeHostProxy::didReceiveCoordinatedLayerTreeHostProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 14 0x7fa0642dedfb WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 15 0x7fa0643396f4 WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 16 0x7fa06437ae8b WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 17 0x7fa06425c72c CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 18 0x7fa06425c898 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) STDERR: 19 0x7fa06425cae3 CoreIPC::Connection::dispatchOneMessage() STDERR: 20 0x7fa06426737a WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) STDERR: 21 0x7fa064267180 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() STDERR: 22 0x7fa06bba2eb2 WTF::Function<void ()>::operator()() const STDERR: 23 0x7fa067c4dd57 WebCore::RunLoop::performWork() STDERR: 24 0x7fa068737d06 WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) STDERR: 25 0x7fa06360b621 STDERR: 26 0x7fa06360a571 STDERR: 27 0x7fa06360aab7 ecore_main_loop_begin STDERR: 28 0x434b05 WTR::TestController::platformRunUntil(bool&, double) STDERR: 29 0x41f50c WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) STDERR: 30 0x426649 WTR::TestInvocation::invoke() STDERR: 31 0x41f244 WTR::TestController::runTest(char const*) STDERR: LEAK: 24 WebCoreNode
Attachments
Patch (2.20 KB, patch)
2013-01-04 04:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-04 04:11:15 PST
Created attachment 181288 [details] Patch
Chris Dumez
Comment 2 2013-01-04 04:20:29 PST
For reference, here is the decoding code: ///// case TimingFunction::CubicBezierFunction: { double x1, y1, x2, y2; CubicBezierTimingFunction::TimingFunctionPreset bezierPreset; if (!decoder->decodeEnum(bezierPreset)) return false; if (bezierPreset != CubicBezierTimingFunction::Custom) { timingFunction = CubicBezierTimingFunction::create(bezierPreset); return true; } if (!decoder->decodeDouble(x1)) return false; if (!decoder->decodeDouble(y1)) return false; if (!decoder->decodeDouble(x2)) return false; if (!decoder->decodeDouble(y2)) return false; timingFunction = CubicBezierTimingFunction::create(x1, y1, x2, y2); return true; } ///// As you can see, it returns early if the bezierPreset is not set custom and it does not decode the x/y parameters. Therefore, we should not encode them in the first place if bezierPreset is not set to custom.
WebKit Review Bot
Comment 3 2013-01-04 04:51:21 PST
Comment on attachment 181288 [details] Patch Clearing flags on attachment: 181288 Committed r138790: <http://trac.webkit.org/changeset/138790>
WebKit Review Bot
Comment 4 2013-01-04 04:51:26 PST
All reviewed patches have been landed. Closing bug.
Alexis Menard (darktears)
Comment 5 2013-01-04 05:20:35 PST
(In reply to comment #4) > All reviewed patches have been landed. Closing bug. Sorry about that.
Note You need to log in before you can comment on or make changes to this bug.