Bug 105925

Summary: [MinGW-w64] Centralize workaround for pow() implementation
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, net147, ojan.autocc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Simon Hausmann
Reported 2013-01-02 08:14:17 PST
[MinGW-w64] Centralize workaround for pow() implementation
Attachments
Patch (3.51 KB, patch)
2013-01-02 08:16 PST, Simon Hausmann 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2013-01-02 08:16:20 PST
Created attachment 181031 [details] Patch
WebKit Review Bot
Comment 2 2013-01-02 08:18:30 PST
Attachment 181031 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/MathExtras.h:230: wtf_pow is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Liu
Comment 3 2013-01-02 13:37:14 PST
Missing blank line before "return pow(x, y);".
Simon Hausmann
Comment 4 2013-01-03 01:56:37 PST
Committed r138705: <http://trac.webkit.org/changeset/138705>
Note You need to log in before you can comment on or make changes to this bug.