Bug 105876

Summary:

[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.

Product:

WebKit

Reporter:

Kalyan <kalyan.kondapally>

Component:

WebKit EFL

Assignee:

Kalyan <kalyan.kondapally>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, noam, rakuco, webkit.review.bot, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

105816

Attachments:

Description	Flags
patch	kenneth: review+, webkit.review.bot: commit-queue-
patchv2	webkit.review.bot: commit-queue-
patch	none

Kalyan

Reported 2012-12-30 14:12:24 PST

This is to sync the naming conventions of our classes in both EGL and GLX implementations. In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.

Attachments
patch (23.18 KB, patch) 2012-12-30 15:18 PST, Kalyan	kenneth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patchv2 (23.16 KB, patch) 2012-12-30 21:24 PST, Kalyan	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch (23.23 KB, patch) 2012-12-30 23:07 PST, Kalyan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kalyan

Comment 1 2012-12-30 15:18:44 PST

Created attachment 180961 [details] patch

WebKit Review Bot

Comment 2 2012-12-30 17:10:39 PST

Comment on attachment 180961 [details] patch Rejecting attachment 180961 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/15589687

Kalyan

Comment 3 2012-12-30 21:24:39 PST

Created attachment 180963 [details] patchv2

WebKit Review Bot

Comment 4 2012-12-30 21:39:51 PST

Comment on attachment 180963 [details] patchv2 Rejecting attachment 180963 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/15585773

Chris Dumez

Comment 5 2012-12-30 21:43:15 PST

Comment on attachment 180963 [details] patchv2 View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review > Source/WebCore/ChangeLog:1 > + [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector. You're missing the first line of this Changelog.

Kalyan

Comment 6 2012-12-30 23:07:47 PST

Created attachment 180965 [details] patch

Kalyan

Comment 7 2012-12-30 23:08:52 PST

(In reply to comment #5) > (From update of attachment 180963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review > > > Source/WebCore/ChangeLog:1 > > + [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector. > > You're missing the first line of this Changelog. thanks. Fixed it now.

WebKit Review Bot

Comment 8 2012-12-30 23:34:17 PST

Comment on attachment 180965 [details] patch Clearing flags on attachment: 180965 Committed r138588: <http://trac.webkit.org/changeset/138588>

WebKit Review Bot

Comment 9 2012-12-30 23:34:23 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.