Bug 105864

Summary: Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, koivisto, macpherson, menard, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2012-12-29 16:44:35 PST
Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
Attachments
Patch (8.63 KB, patch)
2012-12-29 16:46 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2012-12-29 16:46:45 PST
Created attachment 180947 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-29 16:49:27 PST
Comment on attachment 180947 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-12-29 17:24:03 PST
Comment on attachment 180947 [details] Patch Clearing flags on attachment: 180947 Committed r138572: <http://trac.webkit.org/changeset/138572>
WebKit Review Bot
Comment 4 2012-12-29 17:24:07 PST
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 5 2012-12-30 00:35:52 PST
Comment on attachment 180947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180947&action=review > Source/WebCore/css/StyleResolver.cpp:2260 > - SelectorChecker::SelectorMatch match = m_checker.checkSelector(context, m_dynamicPseudo); > + SelectorChecker::SelectorMatch match = m_selectorChecker.checkSelector(context, m_dynamicPseudo); To reduce redundancy it would also be nice to remove the word 'selector' from the SelectorChecker methods.
Antti Koivisto
Comment 6 2012-12-30 00:38:22 PST
...and enums too SelectorChecker::SelectorMatch -> SelectorChecker::Match
Dimitri Glazkov (Google)
Comment 7 2013-01-08 21:06:39 PST
(In reply to comment #6) > ...and enums too > > SelectorChecker::SelectorMatch -> SelectorChecker::Match Good idea! See bug 106413.
Note You need to log in before you can comment on or make changes to this bug.