Bug 105862

Summary: Log to console when target="_blank" links are blocked by sandboxing.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: NEW    
Severity: Normal CC: buildbot, dglazkov, eflews.bot, gyuyoung.kim, japhet, rego+ews, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101964    
Attachments:
Description Flags
Patch none

Mike West
Reported 2012-12-29 13:54:16 PST
The following frame should log to the console when the link is clicked: <iframe sandbox srcdoc="<a href='http://example.com/' target='_blank'>Example</a>"> It currently does nothing at all, which might be a bit confusing for developers.
Attachments
Patch (7.88 KB, patch)
2012-12-29 15:20 PST, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-12-29 15:20:09 PST
Created attachment 180946 [details] Patch
WebKit Review Bot
Comment 2 2012-12-29 16:03:11 PST
Comment on attachment 180946 [details] Patch Attachment 180946 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15592288 New failing tests: fast/frames/sandboxed-iframe-navigation-targetlink.html
Mike West
Comment 3 2012-12-29 16:13:01 PST
Hrm. Apparently PolicyChecker::checkNewWindowPolicy isn't the right place for this console message. I'm not entirely sure why checkNewWindowPolicy gets called in fast/frames/sandboxed-iframe-navigation-targetlink.html, as no windows should be opened... Hrm.
Build Bot
Comment 4 2012-12-29 16:47:31 PST
Comment on attachment 180946 [details] Patch Attachment 180946 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15584371 New failing tests: fast/frames/sandboxed-iframe-navigation-targetlink.html fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html fast/sub-pixel/sub-pixel-accumulates-to-layers.html fast/sub-pixel/transformed-iframe-copy-on-scroll.html
Build Bot
Comment 5 2013-01-15 19:46:27 PST
Comment on attachment 180946 [details] Patch Attachment 180946 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15903196 New failing tests: fast/frames/sandboxed-iframe-navigation-targetlink.html
EFL EWS Bot
Comment 6 2013-04-23 11:25:15 PDT
Comment on attachment 180946 [details] Patch Attachment 180946 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/55974
Anders Carlsson
Comment 7 2014-02-05 11:01:30 PST
Comment on attachment 180946 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.