Bug 105248

Summary: Consider removing --pause-before-testing option
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Cleanup
none
Also remove Driver.start none

Ryosuke Niwa
Reported 2012-12-17 21:10:38 PST
Now that we've added --profile option to run-perf-tests, do we still need --pause-before-testing? We added this option to help us attach profiler but it adds a lot of crafts to various parts in webkitpy.
Attachments
Cleanup (13.10 KB, patch)
2012-12-17 23:01 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Also remove Driver.start (14.16 KB, patch)
2012-12-17 23:10 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-12-17 22:29:33 PST
Completely up to you. :)
Ryosuke Niwa
Comment 2 2012-12-17 22:35:21 PST
(In reply to comment #1) > Completely up to you. :) Alright. Let's get rid of it. I'm planning to make a serious of improvements to run-perf-tests and not having to support it will considerably simplify the patch.
Eric Seidel (no email)
Comment 3 2012-12-17 22:48:15 PST
I would caution you that --profile is not currently designed to handle every possible iprofiler, etc. configuration, so if others are using --pause-before-testing for more exciting profiling, it may still have its uses.
Ryosuke Niwa
Comment 4 2012-12-17 22:53:57 PST
(In reply to comment #3) > I would caution you that --profile is not currently designed to handle every possible iprofiler, etc. configuration, so if others are using --pause-before-testing for more exciting profiling, it may still have its uses. I guess we can always restore it if someone complaints.
Ryosuke Niwa
Comment 5 2012-12-17 23:01:14 PST
Created attachment 179882 [details] Cleanup
Eric Seidel (no email)
Comment 6 2012-12-17 23:04:04 PST
Comment on attachment 179882 [details] Cleanup I believe you can also remove Driver.start() as dpranke told me once it only existed for this option to perf-tests.
Ryosuke Niwa
Comment 7 2012-12-17 23:07:58 PST
(In reply to comment #6) > (From update of attachment 179882 [details]) > I believe you can also remove Driver.start() as dpranke told me once it only existed for this option to perf-tests. Will do.
Ryosuke Niwa
Comment 8 2012-12-17 23:10:06 PST
Created attachment 179883 [details] Also remove Driver.start
Eric Seidel (no email)
Comment 9 2012-12-17 23:15:41 PST
Comment on attachment 179883 [details] Also remove Driver.start This looks fine to me, but you should probably also have dpranke take a look, and probably give folks at least until tomorrow to give comments (since you announced it on webkit-dev). :)
Ryosuke Niwa
Comment 10 2012-12-18 10:56:48 PST
Comment on attachment 179883 [details] Also remove Driver.start Clearing flags on attachment: 179883 Committed r138042: <http://trac.webkit.org/changeset/138042>
Ryosuke Niwa
Comment 11 2012-12-18 10:56:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.