Bug 105208

Summary:

[CSS Exclusions] Differentiate names in the simple rectangle test script

Product:

WebKit

Reporter:

Bear Travis <betravis>

Component:

CSS

Assignee:

Niklas Q Nielsen <nnielsen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

104582

Bug Blocks:

89256

Attachments:

Description	Flags
Rename createRectangleTest and createRectangleTestResult to testRectangle and expectRectangle respectively	none
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectRectangle respectively.	none
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively.	none

Bear Travis

Reported 2012-12-17 13:17:05 PST

createRectangleTest and createRectangleTestResult have similar names, which may lead to misuse. Find a way to differentiate them more clearly.

Attachments
Rename createRectangleTest and createRectangleTestResult to testRectangle and expectRectangle respectively (14.79 KB, patch) 2013-08-22 13:49 PDT, Niklas Q Nielsen	no flags	Details Formatted Diff Diff
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectRectangle respectively. (14.91 KB, patch) 2013-08-22 17:28 PDT, Niklas Q Nielsen	no flags	Details Formatted Diff Diff
Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively. (14.86 KB, patch) 2013-08-26 11:21 PDT, Niklas Q Nielsen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Niklas Q Nielsen

Comment 1 2013-08-22 13:49:56 PDT

Created attachment 209389 [details] Rename createRectangleTest and createRectangleTestResult to testRectangle and expectRectangle respectively

Niklas Q Nielsen

Comment 2 2013-08-22 17:28:16 PDT

Created attachment 209412 [details] Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectRectangle respectively.

Niklas Q Nielsen

Comment 3 2013-08-26 11:21:31 PDT

Created attachment 209665 [details] Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively.

Alexandru Chiculita

Comment 4 2013-08-28 09:52:36 PDT

Comment on attachment 209665 [details] Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively. Looks good. Thanks!

WebKit Commit Bot

Comment 5 2013-08-28 10:10:38 PDT

Comment on attachment 209665 [details] Rename createRectangleTest and createRectangleTestResult to drawTestRectangle and drawExpectedRectangle respectively. Clearing flags on attachment: 209665 Committed r154757: <http://trac.webkit.org/changeset/154757>

WebKit Commit Bot

Comment 6 2013-08-28 10:10:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.