Bug 104826

Summary: REGRESSION: r137481 caused a build failure with GTK
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104538    
Attachments:
Description Flags
Patch for landing none

Noam Rosenthal
Reported 2012-12-12 11:17:56 PST
REGRESSION: r137481 caused a build failure with GTK
Attachments
Patch for landing (1.61 KB, patch)
2012-12-12 11:19 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-12-12 11:19:15 PST
Created attachment 179086 [details] Patch for landing
WebKit Review Bot
Comment 2 2012-12-12 12:43:18 PST
Comment on attachment 179086 [details] Patch for landing Clearing flags on attachment: 179086 Committed r137502: <http://trac.webkit.org/changeset/137502>
WebKit Review Bot
Comment 3 2012-12-12 12:43:21 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2012-12-13 02:51:53 PST
It would be great if you can reference in the original bug about this fixed in the future. Because one more build breaker patch landed during this build break and I thought the build is still broken because of this bug. It's so easy to check the color of the bots from the bed with a smartphone, but it's so hard to check the huge build logs on it. :)
Noam Rosenthal
Comment 5 2012-12-13 06:49:51 PST
(In reply to comment #4) > It would be great if you can reference in the original bug about this fixed > in the future. Because one more build breaker patch landed during this build > break and I thought the build is still broken because of this bug. > > It's so easy to check the color of the bots from the bed with a > smartphone, but it's so hard to check the huge build logs on it. :) Sorry, I was sure I'd done that.
Note You need to log in before you can comment on or make changes to this bug.