Bug 104494

Summary: REGRESSION(r137090): Caused new test failures when JavaScript is embedded in SVG (Requested by mrobinson on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: danw, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104477    
Attachments:
Description Flags
ROLLOUT of r137090
none
jhbuild config changes to patch the regression mrobinson: review+, webkit.review.bot: commit-queue-

WebKit Review Bot
Reported 2012-12-09 14:03:53 PST
http://trac.webkit.org/changeset/137090 broke the build: Caused new test failures when JavaScript is embedded in SVG (Requested by mrobinson on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r137090 (1.45 KB, patch)
2012-12-09 14:04 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
jhbuild config changes to patch the regression (5.06 KB, patch)
2012-12-22 18:44 PST, Dan Winship 		mrobinson: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-12-09 14:04:33 PST
Created attachment 178437 [details] ROLLOUT of r137090 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Dan Winship
Comment 2 2012-12-22 18:44:55 PST
Created attachment 180611 [details] jhbuild config changes to patch the regression (the libxml2 patch has been committed upstream now)
WebKit Review Bot
Comment 3 2012-12-23 09:09:16 PST
Comment on attachment 180611 [details] jhbuild config changes to patch the regression Rejecting attachment 180611 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15511038
Dan Winship
Comment 4 2012-12-23 09:30:40 PST
oops, added the "Reviewed by" line to Tools/ChangeLog and committed by hand.
Note You need to log in before you can comment on or make changes to this bug.