Bug 104461

Summary: Don't unconditionally repaint compositing layers when their size changes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, eric, jamesr, laszlo.gombos, noam, ojan.autocc, ostap73, simon.fraser, thorton, webkit.review.bot, yael
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104637    
Attachments:
Description Flags
Patch
none
Patch jamesr: review+

Simon Fraser (smfr)
Reported 2012-12-08 18:11:41 PST
Don't unconditionally repaint compositing layers when their size changes
Attachments
Patch (5.58 KB, patch)
2012-12-08 18:15 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2012-12-11 22:47 PST, Simon Fraser (smfr) 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-12-08 18:15:27 PST
Created attachment 178389 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-12-08 18:16:11 PST
<rdar://problem/12842382>
Sam Weinig
Comment 3 2012-12-09 17:36:05 PST
Comment on attachment 178389 [details] Patch Eek!
Simon Fraser (smfr)
Comment 4 2012-12-10 15:46:35 PST
http://trac.webkit.org/changeset/137215
Chris Dumez
Comment 5 2012-12-10 23:39:19 PST
The test added in this patch seems to be failing on EFL port: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/compositing/repaint/resize-repaint-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/compositing/repaint/resize-repaint-actual.txt @@ -12,9 +12,6 @@ (position 8.00 8.00) (bounds 402.00 207.00) (drawsContent 1) - (repaint rects - (rect 0.00 1.00 402.00 1.00) - ) ) ) )
Simon Fraser (smfr)
Comment 6 2012-12-11 08:36:18 PST
I didn't think EFL even did compositing. Has that changed? It looks like this port doesn't have the code to track repaint rects on GraphicsLayers. The test should be marked as failing in TestExpectations.
Chris Dumez
Comment 7 2012-12-11 08:40:16 PST
(In reply to comment #6) > I didn't think EFL even did compositing. Has that changed? It looks like this port doesn't have the code to track repaint rects on GraphicsLayers. The test should be marked as failing in TestExpectations. Yes, we have enabled accelerated compositing in WK2 EFL about 1 month ago (using coordinated graphics). Thank you for the indication about tracking repaint rects. I have already marked the test as failing in TestExpectations until we implement the missing functionality.
Simon Fraser (smfr)
Comment 8 2012-12-11 22:38:33 PST
The fix for bug 104626 undid most of this optimization.
Simon Fraser (smfr)
Comment 9 2012-12-11 22:47:40 PST
Created attachment 178971 [details] Patch
Simon Fraser (smfr)
Comment 10 2012-12-12 15:35:12 PST
http://trac.webkit.org/changeset/137526
Note You need to log in before you can comment on or make changes to this bug.