Bug 104432

Summary:

[Qt] Gardening after r137006.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Tools / Tests

Assignee:

Dongseong Hwang <dongseong.hwang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, haraken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

103786

Bug Blocks:

Attachments:

Description	Flags
Patch	dongseong.hwang: review+, dongseong.hwang: commit-queue-
Patch	none

Dongseong Hwang

Reported 2012-12-07 22:14:16 PST

Update existing tests that are affected by r137006.

Attachments
Patch (43.17 KB, patch) 2012-12-07 22:15 PST, Dongseong Hwang	dongseong.hwang: review+ dongseong.hwang: commit-queue-	Details Formatted Diff Diff
Patch (40.94 KB, patch) 2012-12-09 16:54 PST, Dongseong Hwang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dongseong Hwang

Comment 1 2012-12-07 22:15:28 PST

Created attachment 178336 [details] Patch

Kentaro Hara

Comment 2 2012-12-08 00:15:10 PST

Comment on attachment 178336 [details] Patch rs=me. A gardening patch could be landed without review.

WebKit Review Bot

Comment 3 2012-12-08 02:26:40 PST

Comment on attachment 178336 [details] Patch Rejecting attachment 178336 [details] from commit-queue. New failing tests: platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed.html compositing/rtl/rtl-iframe-relative.html compositing/rtl/rtl-iframe-fixed.html compositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative.html Full output: http://queues.webkit.org/results/15214310

WebKit Review Bot

Comment 4 2012-12-08 08:00:09 PST

Comment on attachment 178336 [details] Patch Attachment 178336 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15189710 New failing tests: platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed.html compositing/rtl/rtl-iframe-relative.html compositing/rtl/rtl-iframe-fixed.html compositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative.html

Dongseong Hwang

Comment 5 2012-12-09 16:54:33 PST

Created attachment 178453 [details] Patch

Dongseong Hwang

Comment 6 2012-12-09 16:57:17 PST

(In reply to comment #2) > (From update of attachment 178336 [details]) > rs=me. A gardening patch could be landed without review. Thanks for explanation. I'll do that :)

WebKit Review Bot

Comment 7 2012-12-09 21:10:57 PST

Comment on attachment 178453 [details] Patch Clearing flags on attachment: 178453 Committed r137106: <http://trac.webkit.org/changeset/137106>

WebKit Review Bot

Comment 8 2012-12-09 21:11:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.