Bug 104253

Summary:

[Chromium] Enable CSS3 background-position offset by default.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

CSS

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, ojan, syoichi, tony, webkit.review.bot

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

37514

Attachments:

Description	Flags
Patch	none
Patch	none

Alexis Menard (darktears)

Reported 2012-12-06 04:59:22 PST

[Chromium] Enable CSS3 background-position offset by default.

Attachments
Patch (1.24 KB, patch) 2012-12-06 05:01 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (2.78 KB, patch) 2012-12-06 05:06 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2012-12-06 05:01:42 PST

Created attachment 177995 [details] Patch

Alexis Menard (darktears)

Comment 2 2012-12-06 05:06:28 PST

Created attachment 177996 [details] Patch

Alexis Menard (darktears)

Comment 3 2012-12-06 05:09:37 PST

(In reply to comment #2) > Created an attachment (id=177996) [details] > Patch For the record it is enabled on other ports for some days : Mac, Qt, EFL and GTK. Also as per discussion http://lists.webkit.org/pipermail/webkit-dev/2012-December/023064.html where we decided that when it's ready we'll remove the feature flag (as it is not a major feature). I believe that it's time for it to run on Chromium as well so I can look the bots and remove the feature flag if no problems show up. It is tracked by https://bugs.webkit.org/show_bug.cgi?id=37514

Adam Barth

Comment 4 2012-12-06 08:51:31 PST

I'll defer to Ojan and/or Tony on this one. They likely have more context here.

Alexis Menard (darktears)

Comment 5 2012-12-06 09:09:21 PST

(In reply to comment #4) > I'll defer to Ojan and/or Tony on this one. They likely have more context here. I would also need to rebase a few files on Chromium expected files just as http://trac.webkit.org/changeset/136844 and http://trac.webkit.org/changeset/136847. There were broken expected result anyway. Any pointers on how I can do that on all supported Chromium platforms?

Adam Barth

Comment 6 2012-12-06 09:13:02 PST

> Any pointers on how I can do that on all supported Chromium platforms? Practically speaking, you'll need to land your patch first and then use garden-o-matic.

WebKit Review Bot

Comment 7 2012-12-06 11:54:45 PST

Comment on attachment 177996 [details] Patch Attachment 177996 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15174364 New failing tests: ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm svg/hixie/intrinsic/003.html css2.1/20110323/replaced-intrinsic-003.htm

Alexis Menard (darktears)

Comment 8 2012-12-07 12:35:49 PST

Comment on attachment 177996 [details] Patch Clearing flags on attachment: 177996 Committed r136970: <http://trac.webkit.org/changeset/136970>

Alexis Menard (darktears)

Comment 9 2012-12-07 12:35:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.