Bug 104128

Summary: Coordinated Graphics: Enable support for setContentsToBackgroundColor
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jturcotte, kenneth, ojan, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103786    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Noam Rosenthal
Reported 2012-12-05 08:44:09 PST
Coordinated Graphics: Enable support for setContentsToBackgroundColor
Attachments
Patch (12.26 KB, patch)
2012-12-05 09:01 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (12.01 KB, patch)
2012-12-05 09:31 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (165.84 KB, patch)
2012-12-05 16:28 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (11.39 KB, patch)
2012-12-05 16:53 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-12-05 09:01:38 PST
Created attachment 177765 [details] Patch
Noam Rosenthal
Comment 2 2012-12-05 09:02:48 PST
This would enable us to support direct compositing of background colors, see 103786.
Kenneth Rohde Christiansen
Comment 3 2012-12-05 09:05:14 PST
Comment on attachment 177765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177765&action=review > Source/WebKit2/ChangeLog:9 > + > + Enable setContentsToBackgroundColor in CoordinatedGraphicsLayer, and pass it through to the UI process. > + Better explain what it actually means, what it is used for > Source/WebKit2/ChangeLog:35 > + (WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor): > + * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: > + (CoordinatedGraphicsLayer): > + > +2012-11-30 No'am Rosenthal <noam@webkit.org> > + > + Use background color for GraphicsLayers when applicable > + https://bugs.webkit.org/show_bug.cgi?id=103786 > + > + Reviewed by NOBODY (OOPS!). > + > + Enable setContentsToBackgroundColor for coordinated graphics. > + > + * Shared/WebLayerTreeInfo.h: > + (WebLayerInfo): > + * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp: > + (WebKit::LayerTreeRenderer::setLayerState): > + * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp: > + (WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor): > + * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: > + (CoordinatedGraphicsLayer): why two change log entries?
Noam Rosenthal
Comment 4 2012-12-05 09:31:18 PST
Created attachment 177778 [details] Patch
Noam Rosenthal
Comment 5 2012-12-05 16:28:58 PST
Created attachment 177857 [details] Patch
Noam Rosenthal
Comment 6 2012-12-05 16:33:31 PST
Comment on attachment 177857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177857&action=review > LayoutTests/compositing/overflow/resize-painting-expected.txt:-10 > - (drawsContent 1) This layer actually doesn't draw content; I'm not sure why the expected results have a drawsContent flag.
Noam Rosenthal
Comment 7 2012-12-05 16:49:14 PST
Comment on attachment 177857 [details] Patch Oops, wrong patch.
Noam Rosenthal
Comment 8 2012-12-05 16:53:20 PST
Created attachment 177870 [details] Patch
WebKit Review Bot
Comment 9 2012-12-05 17:24:43 PST
Comment on attachment 177870 [details] Patch Clearing flags on attachment: 177870 Committed r136781: <http://trac.webkit.org/changeset/136781>
WebKit Review Bot
Comment 10 2012-12-05 17:24:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.