Bug 103996

Summary: [Qt] Implement IncrementalSweeper and HeapTimer
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: JavaScriptCoreAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hausmann, jturcotte, laszlo.gombos, levin+threading, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103998, 110211    
Attachments:
Description Flags
Patch
none
Patch
hausmann: review+
Patch
none
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2012-12-04 07:11:10 PST
The IncrementalSweeper performs continous garbage collection as opposed to prompted or forced garbage collection. It relies on HeapTimer which has only been implemented for Mac and Blackberry. Once HeapTimer has been implemented which should also be able to implemented opportunistic garbage collection.
Attachments
Patch (5.88 KB, patch)
2012-12-04 07:15 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (5.97 KB, patch)
2012-12-04 08:42 PST, Allan Sandfeld Jensen 		hausmann: review+
DetailsFormatted DiffDiff
Patch (23.18 KB, patch)
2013-01-08 02:51 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (28.03 KB, patch)
2013-01-08 04:18 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (28.03 KB, patch)
2013-01-08 04:53 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-12-04 07:15:55 PST
Created attachment 177477 [details] Patch
Allan Sandfeld Jensen
Comment 2 2012-12-04 07:17:22 PST
Note the thread-moving code has not been tested. I am unsure under which conditions it would happen.
Allan Sandfeld Jensen
Comment 3 2012-12-04 07:55:33 PST
Comment on attachment 177477 [details] Patch I found the first couple of multithreading issues. Not least of which that QBasicTimer depends on a QThread.
Allan Sandfeld Jensen
Comment 4 2012-12-04 08:42:32 PST
Created attachment 177495 [details] Patch Use postEvent instead of startTimer, and ensure we create the event-dispatcher on construction.
Simon Hausmann
Comment 5 2013-01-03 02:01:26 PST
See also comments in bug #95923 - it sucks that there's so much #ifdeffery for a little bit of platform specific timer code ;( Is it perhaps time to have HeapTimerCF, HeapTimerQt and HeapTimerEFL.cpp?
Allan Sandfeld Jensen
Comment 6 2013-01-08 02:51:39 PST
Created attachment 181678 [details] Patch Split HeapTimer.cpp into platform specific source files. The Mac build is missing an update.
Build Bot
Comment 7 2013-01-08 02:58:13 PST
Comment on attachment 181678 [details] Patch Attachment 181678 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15742915
Build Bot
Comment 8 2013-01-08 03:28:19 PST
Comment on attachment 181678 [details] Patch Attachment 181678 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15756119
Allan Sandfeld Jensen
Comment 9 2013-01-08 04:18:21 PST
Created attachment 181683 [details] Patch Fix build for mac and win
Build Bot
Comment 10 2013-01-08 04:31:26 PST
Comment on attachment 181683 [details] Patch Attachment 181683 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15756136
Allan Sandfeld Jensen
Comment 11 2013-01-08 04:53:51 PST
Created attachment 181685 [details] Patch Another attempt at building on win
Allan Sandfeld Jensen
Comment 12 2013-01-29 02:08:25 PST
Comment on attachment 181685 [details] Patch Splitting the file seems opposed at the moment.
Allan Sandfeld Jensen
Comment 13 2013-01-29 02:53:19 PST
Committed r141089: <http://trac.webkit.org/changeset/141089>
Note You need to log in before you can comment on or make changes to this bug.