Bug 103892

Summary: [Chromium] Fix issue with hard coded error codes in quota error
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, jsbell, michaeln, ojan, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102726    
Attachments:
Description Flags
Patch fishd: review+

Erik Arvidsson
Reported 2012-12-03 07:36:36 PST
[Chromium] Fix issue with hard coded error codes in quota error
Attachments
Patch (1.52 KB, patch)
2012-12-03 07:39 PST, Erik Arvidsson 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-12-03 07:39:01 PST
Created attachment 177252 [details] Patch
Erik Arvidsson
Comment 2 2012-12-03 07:45:49 PST
This is the first step to fix this. Once this is in and a WebKit roll is done to Chrome, the next step is to use the enum names in Chrome instead of the hard coded values. The last step is to then to have these enum values get their values from ExceptionCode.
WebKit Review Bot
Comment 3 2012-12-03 08:10:36 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Darin Fisher (:fishd, Google)
Comment 4 2012-12-03 10:34:29 PST
Comment on attachment 177252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review > Source/WebKit/chromium/public/WebStorageQuotaError.h:39 > + WebStorageQuotaErrorInvalidModification = 13, Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values.
Erik Arvidsson
Comment 5 2012-12-03 11:05:33 PST
(In reply to comment #4) > (From update of attachment 177252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review > > > Source/WebKit/chromium/public/WebStorageQuotaError.h:39 > > + WebStorageQuotaErrorInvalidModification = 13, > > Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values. I added them now since the WebCore side has these already.
Erik Arvidsson
Comment 6 2012-12-03 11:08:18 PST
Committed r136419: <http://trac.webkit.org/changeset/136419>
Darin Fisher (:fishd, Google)
Comment 7 2012-12-03 12:30:52 PST
(In reply to comment #5) > > Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values. > > I added them now since the WebCore side has these already. Cool, thanks.
Note You need to log in before you can comment on or make changes to this bug.