Bug 103864

Summary: Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
Product: WebKit Reporter: Jae Hyun Park <jaepark>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gyuyoung.kim, menard, noam, rakuco, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102994    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jae Hyun Park
Reported 2012-12-03 00:35:32 PST
AreaAllocator and UpdateAtlas is only used for Coordinated Graphics. So, these must be moved to CoordinatedGraphics to clarify the code.
Attachments
Patch (49.94 KB, patch)
2012-12-03 00:51 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (50.12 KB, patch)
2012-12-03 22:55 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (50.12 KB, patch)
2012-12-04 01:10 PST, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jae Hyun Park
Comment 1 2012-12-03 00:51:58 PST
Created attachment 177201 [details] Patch
Dongseong Hwang
Comment 2 2012-12-03 17:37:57 PST
Comment on attachment 177201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21 > + We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas. Do we need to add Coordinated prefix?
Jae Hyun Park
Comment 3 2012-12-03 22:55:01 PST
Created attachment 177420 [details] Patch
Jae Hyun Park
Comment 4 2012-12-03 22:57:15 PST
(In reply to comment #2) > (From update of attachment 177201 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21 > > + > > We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas. Fixed. > Do we need to add Coordinated prefix? I'm not sure about this. Any comments?
Kenneth Rohde Christiansen
Comment 5 2012-12-04 00:43:02 PST
Comment on attachment 177420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review > Source/WebKit2/ChangeLog:8 > + AreaAllocator and UpdateAtlas is only used for Coordinated Graphics. are* > Source/WebKit2/ChangeLog:9 > + So, these must be moved to CoordinatedGraphics to clarify the code. s/much/should > Source/WebKit2/ChangeLog:12 > + So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again?
Jae Hyun Park
Comment 6 2012-12-04 01:10:15 PST
Created attachment 177440 [details] Patch
Jae Hyun Park
Comment 7 2012-12-04 01:22:12 PST
(In reply to comment #5) > (From update of attachment 177420 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review > > > Source/WebKit2/ChangeLog:8 > > + AreaAllocator and UpdateAtlas is only used for Coordinated Graphics. > > are* Fixed. > > > Source/WebKit2/ChangeLog:9 > > + So, these must be moved to CoordinatedGraphics to clarify the code. > > s/much/should Fixed. > > > Source/WebKit2/ChangeLog:12 > > + > > So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again? Thanks for the review! First of all, UpdateAtlas is not used in any other codes other than Coordinated Graphics. So, it belongs to Coordinated Graphics. Also, as far as I know, there aren't any plans on using UpdateAtlas other than Coordinated Graphics.
WebKit Review Bot
Comment 8 2012-12-05 13:58:18 PST
Comment on attachment 177440 [details] Patch Clearing flags on attachment: 177440 Committed r136760: <http://trac.webkit.org/changeset/136760>
WebKit Review Bot
Comment 9 2012-12-05 13:58:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.