Bug 103710

Summary:

[EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found

Product:

WebKit

Reporter:

Kalyan <kalyan.kondapally>

Component:

WebKit EFL

Assignee:

Kalyan <kalyan.kondapally>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, gyuyoung.kim, kenneth, lucas.de.marchi, noam, rakuco, webkit.review.bot, yael, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

102991

Attachments:

Description	Flags
GraphicsSurfaceConfig	none
GraphicsSurfaceConfig	kenneth: review+, webkit.review.bot: commit-queue-
GraphicsSurfaceConfig	none

Kalyan

Reported 2012-11-29 22:04:11 PST

When using GLX back-end we are dependent on GLX support, Xcomposite and Xrender extensions. In this case GraphicsSurface usage depends on Xcomposite and Xrender extensions. USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.

Attachments
GraphicsSurfaceConfig (5.99 KB, patch) 2012-11-29 23:46 PST, Kalyan	no flags	Details Formatted Diff Diff
GraphicsSurfaceConfig (5.99 KB, patch) 2012-11-30 00:07 PST, Kalyan	kenneth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
GraphicsSurfaceConfig (5.95 KB, patch) 2012-12-03 22:55 PST, Kalyan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kalyan

Comment 1 2012-11-29 22:05:53 PST

(In reply to comment #0) > When using GLX back-end we are dependent on GLX support, Xcomposite and Xrender extensions. > In this case GraphicsSurface usage depends on Xcomposite and Xrender extensions. USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found. This is in case of WebGL

Kalyan

Comment 2 2012-11-29 23:46:02 PST

Created attachment 176906 [details] GraphicsSurfaceConfig

Kalyan

Comment 3 2012-11-30 00:01:05 PST

Comment on attachment 176906 [details] GraphicsSurfaceConfig removing review flag. Will update a new patch. In PlatformSurface the check should be done using USE rather than HAVE(GRAPHICS_SURFACE)

Kalyan

Comment 4 2012-11-30 00:07:45 PST

Created attachment 176908 [details] GraphicsSurfaceConfig

Kenneth Rohde Christiansen

Comment 5 2012-11-30 00:52:14 PST

Comment on attachment 176908 [details] GraphicsSurfaceConfig View in context: https://bugs.webkit.org/attachment.cgi?id=176908&action=review > ChangeLog:4 > + [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found. > + https://bugs.webkit.org/show_bug.cgi?id=103710. I guess we need similar checks for EGL > Source/cmake/OptionsEfl.cmake:196 > - SET (ENABLE_WEBGL 1) > - ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1) > + SET(ENABLE_WEBGL 1) > + IF (USE_GRAPHICS_SURFACE) > + ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1) > + ENDIF() > ENDIF() > isnt the identation wrong?

Kalyan

Comment 6 2012-11-30 07:44:10 PST

(In reply to comment #5) > (From update of attachment 176908 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176908&action=review > > > ChangeLog:4 > > + [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found. > > + https://bugs.webkit.org/show_bug.cgi?id=103710. > > I guess we need similar checks for EGL Yes, once we start adding support for EGL > > Source/cmake/OptionsEfl.cmake:196 > > - SET (ENABLE_WEBGL 1) > > - ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1) > > + SET(ENABLE_WEBGL 1) > > + IF (USE_GRAPHICS_SURFACE) > > + ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1) > > + ENDIF() > > ENDIF() > > > > isnt the identation wrong? w.r.t this file the indentation seems to be mixed (2 space and 4 space). But, here https://bugs.webkit.org/show_bug.cgi?id=102687#c9 rakuco mentioned that we should follow 4 space indentation style.

WebKit Review Bot

Comment 7 2012-11-30 08:13:46 PST

Comment on attachment 176908 [details] GraphicsSurfaceConfig Rejecting attachment 176908 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15055456

Kalyan

Comment 8 2012-12-03 22:55:40 PST

Created attachment 177421 [details] GraphicsSurfaceConfig

WebKit Review Bot

Comment 9 2012-12-04 01:12:54 PST

Comment on attachment 177421 [details] GraphicsSurfaceConfig Clearing flags on attachment: 177421 Committed r136487: <http://trac.webkit.org/changeset/136487>

WebKit Review Bot

Comment 10 2012-12-04 01:13:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.